From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D9C5C54EBE for ; Tue, 10 Jan 2023 05:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229893AbjAJFLq (ORCPT ); Tue, 10 Jan 2023 00:11:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbjAJFLU (ORCPT ); Tue, 10 Jan 2023 00:11:20 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11FAE559F for ; Mon, 9 Jan 2023 21:10:59 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id g10so7931760wmo.1 for ; Mon, 09 Jan 2023 21:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ReLrFKfh84Gdpa+LdX4DPx8RCW3Nljx3Icxd0DnXzMM=; b=c+lId2L4pVgcH5fy5tDRrbzQ+zwf2zRsw6czeqLhJTvuwauFvIYRQMjK0PgSMFqlsL GglxNottTD6N5z0326XcV26CJ08rehQYgAekxArh6g8HqKKdMxbcrUFFpFMRYGOQByI/ WS1z53aA5UHEvEWD4lYDGQEPoGx6sdmdEms6a1/UFeb37AAztLFcODwKvJt+SWATvn2H 0LPkqUsIuLedIY1izEMQufAT24i203pm1N8X5S/1lODdKSJmME2gMA9Q5aZSvhMABf3b AfL82vsGdN33ChM6jNZ2wFiK9MDkYcJRLysb+mXD/Y9IPjPWTg/THn9dN5ggC883LdgC GocA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ReLrFKfh84Gdpa+LdX4DPx8RCW3Nljx3Icxd0DnXzMM=; b=i7auU1pBNcD9SC5Kk6ULs4HfY/Egf5KZfZf11sOTUa5NyDzOeuSQTJyl5VQIyxfiYP niYhvfLkF83sR9sHgDFX4KZqhydiFoF9nA6H396wvPWkfmzY3OKS4rlIebx+gZLKZFT5 LxWd08PAt3uUdZB/+C61pJ793hXqB9oq+1wynboFduGbS6GqBGXRbTT9S0K7zNvq3VJc ZsulxVZNJK7IkJiRH8XWR2S+6Ew+wPPUtR7eZ63tP/bligpFSWryx4fPMUbecDmnaQmi NIqwmztnX6n9U3B1JmTHtKcfkBiFvsZnAKtCmX+vsXA0vHC8kNNUdnAKF4N/ApEEH5C3 HdUw== X-Gm-Message-State: AFqh2krf9lF7bcFq9HWbC+XDQLEDYJr6k2MFrddp2YViSixxyNG48X38 Eosc/ahSI96cDV+jTGfEW/s= X-Google-Smtp-Source: AMrXdXu80iYOf41zcXmSavZBRXwqwt8pB/CK4L/ZGBNVwSJ4xDOhhlw0DvirLKNy3Hqc6hjPmlArTQ== X-Received: by 2002:a05:600c:35cc:b0:3d3:3c93:af34 with SMTP id r12-20020a05600c35cc00b003d33c93af34mr58559524wmq.2.1673327458290; Mon, 09 Jan 2023 21:10:58 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id t12-20020a05600c198c00b003d9de0c39fasm16707235wmq.36.2023.01.09.21.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 21:10:57 -0800 (PST) Date: Tue, 10 Jan 2023 08:10:54 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Maxim Mikityanskiy Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Jakub Kicinski , Tariq Toukan , Saeed Mahameed Subject: drivers/net/ethernet/mellanox/mlx5/core/en/params.c:481 mlx5e_mpwrq_validate_xsk() error: we previously assumed 'xsk' could be null (see line 478) Message-ID: <202301100424.sL6nSNSL-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 1fe4fd6f5cad346e598593af36caeadc4f5d4fa9 commit: 6470d2e7e8ed8e9dd560d8dc3e09d1100a17ee26 net/mlx5e: xsk: Use KSM for unaligned XSK config: i386-randconfig-m021-20230102 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter New smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/params.c:481 mlx5e_mpwrq_validate_xsk() error: we previously assumed 'xsk' could be null (see line 478) Old smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/en/params.c:314 mlx5e_mpwqe_get_log_num_strides() warn: signedness bug returning '(-255)' vim +/xsk +481 drivers/net/ethernet/mellanox/mlx5/core/en/params.c 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 474 int mlx5e_mpwrq_validate_xsk(struct mlx5_core_dev *mdev, struct mlx5e_params *params, 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 475 struct mlx5e_xsk_param *xsk) 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 476 { e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 477 u8 page_shift = mlx5e_mpwrq_page_shift(mdev, xsk); 6470d2e7e8ed8e Maxim Mikityanskiy 2022-09-29 @478 bool unaligned = xsk ? xsk->unaligned : false; ^^^ Assumes xsk can be NULL e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 479 u16 max_mtu_pkts; e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 480 6470d2e7e8ed8e Maxim Mikityanskiy 2022-09-29 @481 if (!mlx5e_check_fragmented_striding_rq_cap(mdev, page_shift, xsk->unaligned)) ^^^^^ Unchecked dereference 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 482 return -EOPNOTSUPP; 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 483 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 484 if (!mlx5e_rx_mpwqe_is_linear_skb(mdev, params, xsk)) 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 485 return -EINVAL; 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 486 e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 487 /* Current RQ length is too big for the given frame size, the e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 488 * needed number of WQEs exceeds the maximum. e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 489 */ e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 490 max_mtu_pkts = min_t(u8, MLX5E_PARAMS_MAXIMUM_LOG_RQ_SIZE, 6470d2e7e8ed8e Maxim Mikityanskiy 2022-09-29 491 mlx5e_mpwrq_max_log_rq_pkts(mdev, page_shift, unaligned)); e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 492 if (params->log_rq_mtu_frames > max_mtu_pkts) { e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 493 mlx5_core_err(mdev, "Current RQ length %d is too big for XSK with given frame size %u\n", e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 494 1 << params->log_rq_mtu_frames, xsk->chunk_size); e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 495 return -EINVAL; e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 496 } e5a3cc83d54019 Maxim Mikityanskiy 2022-09-29 497 44f4fd03b51705 Maxim Mikityanskiy 2022-09-27 498 return 0; b3a131c2a1602e Tariq Toukan 2021-03-07 499 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests