From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Johan Hovold" <johan@kernel.org>,
"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
"Rodolfo Giometti" <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 00/13] tty/serial: bool conversions and cleanups
Date: Tue, 10 Jan 2023 14:02:13 +0200 [thread overview]
Message-ID: <20230110120226.14972-1-ilpo.jarvinen@linux.intel.com> (raw)
There are number of functions in tty/serial which have arguments or
return types that expect/behave like bool. Likely due to them existing
before bool was available, other types are used. Make conversions to
bool and cleanups.
v2:
- Call dtr/rts parameters/variables consistently "active"
- Don't chain one return statement with ||
- Don't change function signatures to >80 chars ("while at it")
- moxa: differentiated dtr and status variables
Ilpo Järvinen (13):
tty: Cleanup tty_port_set_initialized() bool parameter
tty: Cleamup tty_port_set_suspended() bool parameter
tty: Cleanup tty_port_set_active() bool parameter
tty: moxa: Make local var storing tty_port_initialized() bool
serial: Convert uart_{,port_}startup() init_hw param to bool
tty: Convert ->carrier_raised() and callchains to bool
tty: Convert ->dtr_rts() to take bool argument
tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool
active
serial: Make uart_handle_cts_change() status param bool active
tty: Return bool from tty_termios_hw_change()
tty/serial: Call ->dtr_rts() parameter active consistently
tty: moxa: Rename dtr/rts parameters/variables to active
usb/serial: Rename dtr/rts parameters/variables to active
drivers/char/pcmcia/synclink_cs.c | 18 +++----
drivers/ipack/devices/ipoctal.c | 4 +-
drivers/mmc/core/sdio_uart.c | 13 +++--
drivers/pps/clients/pps-ldisc.c | 6 +--
drivers/s390/char/con3215.c | 4 +-
drivers/staging/greybus/uart.c | 4 +-
drivers/tty/amiserial.c | 12 ++---
drivers/tty/hvc/hvc_console.c | 4 +-
drivers/tty/hvc/hvc_console.h | 2 +-
drivers/tty/hvc/hvc_iucv.c | 6 +--
drivers/tty/moxa.c | 80 ++++++++++++++--------------
drivers/tty/mxser.c | 11 ++--
drivers/tty/n_gsm.c | 16 +++---
drivers/tty/serial/imx.c | 2 +-
drivers/tty/serial/max3100.c | 2 +-
drivers/tty/serial/max310x.c | 3 +-
drivers/tty/serial/serial_core.c | 65 +++++++++++-----------
drivers/tty/serial/sunhv.c | 8 +--
drivers/tty/synclink_gt.c | 21 ++++----
drivers/tty/tty_ioctl.c | 8 +--
drivers/tty/tty_port.c | 22 ++++----
drivers/usb/class/cdc-acm.c | 4 +-
drivers/usb/serial/ch341.c | 11 ++--
drivers/usb/serial/console.c | 2 +-
drivers/usb/serial/cp210x.c | 6 +--
drivers/usb/serial/cypress_m8.c | 6 +--
drivers/usb/serial/digi_acceleport.c | 6 +--
drivers/usb/serial/f81232.c | 10 ++--
drivers/usb/serial/f81534.c | 4 +-
drivers/usb/serial/ftdi_sio.c | 6 +--
drivers/usb/serial/generic.c | 10 ++--
drivers/usb/serial/ipw.c | 8 +--
drivers/usb/serial/keyspan.c | 6 +--
drivers/usb/serial/keyspan_pda.c | 4 +-
drivers/usb/serial/mct_u232.c | 6 +--
drivers/usb/serial/mxuport.c | 4 +-
drivers/usb/serial/pl2303.c | 11 ++--
drivers/usb/serial/quatech2.c | 6 +--
drivers/usb/serial/sierra.c | 6 +--
drivers/usb/serial/spcp8x5.c | 11 ++--
drivers/usb/serial/ssu100.c | 6 +--
drivers/usb/serial/upd78f0730.c | 8 +--
drivers/usb/serial/usb-serial.c | 8 +--
drivers/usb/serial/usb-wwan.h | 2 +-
drivers/usb/serial/usb_wwan.c | 6 +--
drivers/usb/serial/xr_serial.c | 8 +--
include/linux/serial_core.h | 6 +--
include/linux/tty.h | 2 +-
include/linux/tty_ldisc.h | 4 +-
include/linux/tty_port.h | 10 ++--
include/linux/usb/serial.h | 6 +--
net/bluetooth/rfcomm/tty.c | 2 +-
52 files changed, 247 insertions(+), 259 deletions(-)
--
2.30.2
next reply other threads:[~2023-01-10 12:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 12:02 Ilpo Järvinen [this message]
2023-01-10 12:02 ` [PATCH v2 01/13] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 02/13] tty: Cleamup tty_port_set_suspended() " Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 03/13] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 04/13] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 05/13] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-11 5:53 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 06/13] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 07/13] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active Ilpo Järvinen
2023-01-10 12:02 ` [PATCH v2 09/13] serial: Make uart_handle_cts_change() status param " Ilpo Järvinen
2023-01-11 5:54 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 10/13] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-11 5:55 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 11/13] tty/serial: Call ->dtr_rts() parameter active consistently Ilpo Järvinen
2023-01-11 5:56 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 12/13] tty: moxa: Rename dtr/rts parameters/variables to active Ilpo Järvinen
2023-01-11 5:59 ` Jiri Slaby
2023-01-10 12:02 ` [PATCH v2 13/13] usb/serial: " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110120226.14972-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=giometti@enneenne.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox