From: Bjorn Helgaas <helgaas@kernel.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Luck, Tony" <tony.luck@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"hdegoede@redhat.com" <hdegoede@redhat.com>,
"kernelorg@undead.fr" <kernelorg@undead.fr>,
"kjhambrick@gmail.com" <kjhambrick@gmail.com>,
"2lprbe78@duck.com" <2lprbe78@duck.com>,
"nicholas.johnson-opensource@outlook.com.au"
<nicholas.johnson-opensource@outlook.com.au>,
"benoitg@coeus.ca" <benoitg@coeus.ca>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"wse@tuxedocomputers.com" <wse@tuxedocomputers.com>,
"mumblingdrunkard@protonmail.com"
<mumblingdrunkard@protonmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Box, David E" <david.e.box@intel.com>,
"Sun, Yunying" <yunying.sun@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>
Subject: Re: Bug report: the extended PCI config space is missed with 6.2-rc2
Date: Tue, 10 Jan 2023 13:06:57 -0600 [thread overview]
Message-ID: <20230110190657.GA1600529@bhelgaas> (raw)
In-Reply-To: <2287772.ElGaqSPkdT@kreacher>
On Tue, Jan 10, 2023 at 07:12:42PM +0100, Rafael J. Wysocki wrote:
> On Friday, January 6, 2023 11:04:49 PM CET Bjorn Helgaas wrote:
> ...
> > The below should work better.
> >
> > commit 696ac9286d3d ("x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space")
> > parent 1b929c02afd3
> > Author: Bjorn Helgaas <bhelgaas@google.com>
> > Date: Thu Jan 5 16:02:58 2023 -0600
> >
> > x86/pci: Treat EfiMemoryMappedIO as reservation of ECAM space
> >
> > Normally we reject ECAM space unless it is reported as reserved in the E820
> > table or via a PNP0C02 _CRS method (PCI Firmware, r3.3, sec 4.1.2). This
> > means extended config space (offsets 0x100-0xfff) may not be accessible.
> >
> > Some firmware doesn't report ECAM space via PNP0C02 _CRS methods, but does
> > mention it as an EfiMemoryMappedIO region via EFI GetMemoryMap(), which is
> > normally converted to an E820 entry by a bootloader or EFI stub.
> >
> > 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map"), removes
> > E820 entries that correspond to EfiMemoryMappedIO regions because some
> > other firmware uses EfiMemoryMappedIO for PCI host bridge windows, and the
> > E820 entries prevent Linux from allocating BAR space for hot-added devices.
> >
> > Allow use of ECAM for extended config space when the region is covered by
> > an EfiMemoryMappedIO region, even if it's not included in E820 or PNP0C02
> > _CRS.
> >
> > Fixes: 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map")
> > Link: https://lore.kernel.org/r/ac2693d8-8ba3-72e0-5b66-b3ae008d539d@linux.intel.com
>
> This prints quite a few debug-level messages to dmesg. I guess you'll post an
> update with fewer of them?
Right, this was a debugging patch.
> In any case, please feel free to add
>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Thanks!
next prev parent reply other threads:[~2023-01-10 19:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 14:39 Bug report: the extended PCI config space is missed with 6.2-rc2 Liang, Kan
2023-01-04 14:50 ` Bjorn Helgaas
2023-01-04 15:45 ` Bjorn Helgaas
2023-01-05 17:42 ` Tony Luck
2023-01-05 17:51 ` Bjorn Helgaas
2023-01-05 18:04 ` Luck, Tony
2023-01-05 18:29 ` Bjorn Helgaas
2023-01-05 19:23 ` Liang, Kan
2023-01-05 19:44 ` Bjorn Helgaas
2023-01-05 19:44 ` Dan Williams
2023-01-05 19:58 ` Luck, Tony
2023-01-05 20:37 ` Bjorn Helgaas
2023-01-05 21:49 ` Luck, Tony
2023-01-05 22:20 ` Bjorn Helgaas
2023-01-05 20:23 ` Bjorn Helgaas
2023-01-05 21:20 ` Dan Williams
2023-01-05 21:35 ` Bjorn Helgaas
2023-01-05 21:43 ` Dan Williams
2023-01-05 21:48 ` Bjorn Helgaas
2023-01-05 22:32 ` Bjorn Helgaas
2023-01-05 23:38 ` Dan Williams
2023-01-06 0:22 ` Luck, Tony
2023-01-06 0:47 ` Bjorn Helgaas
2023-01-06 17:33 ` Bjorn Helgaas
2023-01-06 18:03 ` Luck, Tony
2023-01-06 20:52 ` Bjorn Helgaas
2023-01-06 21:37 ` Luck, Tony
2023-01-06 22:04 ` Bjorn Helgaas
2023-01-06 22:30 ` Luck, Tony
2023-01-10 5:43 ` Sun, Yunying
2023-01-10 18:12 ` Rafael J. Wysocki
2023-01-10 19:06 ` Bjorn Helgaas [this message]
2023-01-06 0:32 ` Bjorn Helgaas
2023-01-06 0:50 ` Liang, Kan
2023-01-09 12:27 ` Giovanni Cabiddu
2023-01-10 6:03 ` Sun, Yunying
2023-01-06 9:44 ` Linux kernel regression tracking (#adding)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110190657.GA1600529@bhelgaas \
--to=helgaas@kernel.org \
--cc=2lprbe78@duck.com \
--cc=benoitg@coeus.ca \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david.e.box@intel.com \
--cc=hdegoede@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=kernelorg@undead.fr \
--cc=kjhambrick@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mumblingdrunkard@protonmail.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=wse@tuxedocomputers.com \
--cc=yunying.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox