* [PATCH v1 1/1] gpio: davinci: Remove duplicate assignment of of_gpio_n_cells
@ 2023-01-12 16:38 Andy Shevchenko
2023-01-16 8:40 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-12 16:38 UTC (permalink / raw)
To: Devarsh Thakkar, linux-gpio, linux-kernel
Cc: Keerthy, Linus Walleij, Bartosz Golaszewski, Andy Shevchenko
The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-davinci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index e1c1b9a527db..26b1f7465e09 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -252,7 +252,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
chips->chip.base = pdata->no_auto_base ? pdata->base : -1;
#ifdef CONFIG_OF_GPIO
- chips->chip.of_gpio_n_cells = 2;
chips->chip.parent = dev;
chips->chip.request = gpiochip_generic_request;
chips->chip.free = gpiochip_generic_free;
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] gpio: davinci: Remove duplicate assignment of of_gpio_n_cells
2023-01-12 16:38 [PATCH v1 1/1] gpio: davinci: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
@ 2023-01-16 8:40 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2023-01-16 8:40 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Devarsh Thakkar, linux-gpio, linux-kernel, Keerthy, Linus Walleij
On Thu, Jan 12, 2023 at 5:38 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/gpio/gpio-davinci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index e1c1b9a527db..26b1f7465e09 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -252,7 +252,6 @@ static int davinci_gpio_probe(struct platform_device *pdev)
> chips->chip.base = pdata->no_auto_base ? pdata->base : -1;
>
> #ifdef CONFIG_OF_GPIO
> - chips->chip.of_gpio_n_cells = 2;
> chips->chip.parent = dev;
> chips->chip.request = gpiochip_generic_request;
> chips->chip.free = gpiochip_generic_free;
> --
> 2.39.0
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-16 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-12 16:38 [PATCH v1 1/1] gpio: davinci: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-16 8:40 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox