From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B46C61DB3 for ; Thu, 12 Jan 2023 18:59:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235023AbjALS7H (ORCPT ); Thu, 12 Jan 2023 13:59:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232919AbjALS6c (ORCPT ); Thu, 12 Jan 2023 13:58:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC1E3266E; Thu, 12 Jan 2023 10:34:24 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 51D586214C; Thu, 12 Jan 2023 18:34:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82B66C433D2; Thu, 12 Jan 2023 18:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673548463; bh=M36E0az9apj/WWDPm0/qsCtZyG5YVmwB7+9Ke5kQ8LU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=sPSsKpSMDwEcWp40JGwOPacz6FK0Cr2zqz0qCkOPDZ8q7+P9fxiCSb/9sksSbOR9x M1aOoEkm0rO8Bv+1/l4jtqekz5zEI8kbU6mqWCZHwv58ut/km0/wGEBUA6Imv6PpXP 2ngfp9Aino6ysyS1BMe4eQebFM65xlVnArOuS+D/RHCISDY6qKELCTi49Y6A1kHX/H 9A5hC+9aZdHTOPNAMgDRA9maQ0aBgMaJ3P1UC5SURxqVsVJYPf5sHiLZoZH2qurC0m 4yJXHqztabzDiFVA7s4KzandIcus89kPPAERFSUn63FRBm67QwN0j1jc0HAdjzNuJy 5/zHqWxz5T1kg== Date: Thu, 12 Jan 2023 12:34:22 -0600 From: Bjorn Helgaas To: Baolu Lu Cc: Jason Gunthorpe , Bjorn Helgaas , Joerg Roedel , Christian =?iso-8859-1?Q?K=F6nig?= , Kevin Tian , Vasant Hegde , Tony Zhu , linux-pci@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Matt Fagnani Subject: Re: [PATCH 1/1] PCI: Add translated request only opt-in for pci_enable_pasid() Message-ID: <20230112183422.GA1778973@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78a15f05-29d7-9dd3-175a-3915e7357c11@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 09:25:25PM +0800, Baolu Lu wrote: > On 2023/1/12 20:38, Jason Gunthorpe wrote: > > On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote: > > > > > -int pci_enable_pasid(struct pci_dev *pdev, int features); > > > +int pci_enable_pasid(struct pci_dev *pdev, int features, bool > > > transled_only); ^^^^^^^^ > + * @flags: device-specific flags > + * - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID > + * memory requests of translated type. ^^^^^^^^ I don't like "transled" since it's not a word itself or an obvious combination of "translated" and something else. Not sure whether you need to abbreviate it, but if you do, "xlate" is a common shortening of "translate". Bjorn