* [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
@ 2023-01-14 16:22 Johan Hovold
2023-01-15 4:25 ` Manivannan Sadhasivam
2023-01-15 12:11 ` Daniele Palmas
0 siblings, 2 replies; 4+ messages in thread
From: Johan Hovold @ 2023-01-14 16:22 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Catalin Marinas, Will Deacon, Manivannan Sadhasivam, Abel Vesa,
linux-arm-msm, linux-arm-kernel, linux-kernel, Johan Hovold
Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
based PCIe modems such as the ones found on the SC8280XP Compute
Reference Design (CRD) and Lenovo Thinkpad X13s.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
Bjorn,
Perhaps you can take this through your tree?
Johan
arch/arm64/configs/defconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 86aa3730a8b6..117b49f3f1c1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
CONFIG_FW_LOADER_USER_HELPER=y
CONFIG_HISILICON_LPC=y
CONFIG_TEGRA_ACONNECT=m
+CONFIG_MHI_BUS_PCI_GENERIC=m
CONFIG_ARM_SCMI_PROTOCOL=y
CONFIG_ARM_SCPI_PROTOCOL=y
CONFIG_RASPBERRYPI_FIRMWARE=y
@@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
CONFIG_MWIFIEX_PCIE=m
CONFIG_WL18XX=m
CONFIG_WLCORE_SDIO=m
+CONFIG_WWAN=m
+CONFIG_MHI_WWAN_CTRL=m
+CONFIG_MHI_WWAN_MBIM=m
CONFIG_INPUT_EVDEV=y
CONFIG_KEYBOARD_ADC=m
CONFIG_KEYBOARD_GPIO=y
--
2.38.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
2023-01-14 16:22 [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers Johan Hovold
@ 2023-01-15 4:25 ` Manivannan Sadhasivam
2023-01-15 12:11 ` Daniele Palmas
1 sibling, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2023-01-15 4:25 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Catalin Marinas, Will Deacon, Abel Vesa,
linux-arm-msm, linux-arm-kernel, linux-kernel
On Sat, Jan 14, 2023 at 05:22:36PM +0100, Johan Hovold wrote:
> Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> based PCIe modems such as the ones found on the SC8280XP Compute
> Reference Design (CRD) and Lenovo Thinkpad X13s.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
>
> Bjorn,
>
> Perhaps you can take this through your tree?
>
> Johan
>
>
> arch/arm64/configs/defconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 86aa3730a8b6..117b49f3f1c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> CONFIG_FW_LOADER_USER_HELPER=y
> CONFIG_HISILICON_LPC=y
> CONFIG_TEGRA_ACONNECT=m
> +CONFIG_MHI_BUS_PCI_GENERIC=m
> CONFIG_ARM_SCMI_PROTOCOL=y
> CONFIG_ARM_SCPI_PROTOCOL=y
> CONFIG_RASPBERRYPI_FIRMWARE=y
> @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
> CONFIG_MWIFIEX_PCIE=m
> CONFIG_WL18XX=m
> CONFIG_WLCORE_SDIO=m
> +CONFIG_WWAN=m
> +CONFIG_MHI_WWAN_CTRL=m
> +CONFIG_MHI_WWAN_MBIM=m
> CONFIG_INPUT_EVDEV=y
> CONFIG_KEYBOARD_ADC=m
> CONFIG_KEYBOARD_GPIO=y
> --
> 2.38.2
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
2023-01-14 16:22 [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers Johan Hovold
2023-01-15 4:25 ` Manivannan Sadhasivam
@ 2023-01-15 12:11 ` Daniele Palmas
2023-01-15 17:42 ` Johan Hovold
1 sibling, 1 reply; 4+ messages in thread
From: Daniele Palmas @ 2023-01-15 12:11 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Catalin Marinas, Will Deacon,
Manivannan Sadhasivam, Abel Vesa, linux-arm-msm, linux-arm-kernel,
linux-kernel
Hello Johan,
Il giorno sab 14 gen 2023 alle ore 17:23 Johan Hovold
<johan+linaro@kernel.org> ha scritto:
>
> Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> based PCIe modems such as the ones found on the SC8280XP Compute
> Reference Design (CRD) and Lenovo Thinkpad X13s.
>
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>
> Bjorn,
>
> Perhaps you can take this through your tree?
>
> Johan
>
>
> arch/arm64/configs/defconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 86aa3730a8b6..117b49f3f1c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> CONFIG_FW_LOADER_USER_HELPER=y
> CONFIG_HISILICON_LPC=y
> CONFIG_TEGRA_ACONNECT=m
> +CONFIG_MHI_BUS_PCI_GENERIC=m
> CONFIG_ARM_SCMI_PROTOCOL=y
> CONFIG_ARM_SCPI_PROTOCOL=y
> CONFIG_RASPBERRYPI_FIRMWARE=y
> @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
> CONFIG_MWIFIEX_PCIE=m
> CONFIG_WL18XX=m
> CONFIG_WLCORE_SDIO=m
> +CONFIG_WWAN=m
> +CONFIG_MHI_WWAN_CTRL=m
> +CONFIG_MHI_WWAN_MBIM=m
wondering if it could make sense to also enable CONFIG_MHI_NET, since
in mhi_pci_generic there are also modems bound to that driver and, if
not enabled, those would show just the control device, but not the
netdevice.
Regards,
Daniele
> CONFIG_INPUT_EVDEV=y
> CONFIG_KEYBOARD_ADC=m
> CONFIG_KEYBOARD_GPIO=y
> --
> 2.38.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers
2023-01-15 12:11 ` Daniele Palmas
@ 2023-01-15 17:42 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2023-01-15 17:42 UTC (permalink / raw)
To: Daniele Palmas
Cc: Johan Hovold, Bjorn Andersson, Catalin Marinas, Will Deacon,
Manivannan Sadhasivam, Abel Vesa, linux-arm-msm, linux-arm-kernel,
linux-kernel
On Sun, Jan 15, 2023 at 01:11:08PM +0100, Daniele Palmas wrote:
> Hello Johan,
>
> Il giorno sab 14 gen 2023 alle ore 17:23 Johan Hovold
> <johan+linaro@kernel.org> ha scritto:
> >
> > Enable the MHI PCI controller driver and MHI WWAN drivers for Qualcomm
> > based PCIe modems such as the ones found on the SC8280XP Compute
> > Reference Design (CRD) and Lenovo Thinkpad X13s.
> >
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> > ---
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index 86aa3730a8b6..117b49f3f1c1 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -250,6 +250,7 @@ CONFIG_DEVTMPFS_MOUNT=y
> > CONFIG_FW_LOADER_USER_HELPER=y
> > CONFIG_HISILICON_LPC=y
> > CONFIG_TEGRA_ACONNECT=m
> > +CONFIG_MHI_BUS_PCI_GENERIC=m
> > CONFIG_ARM_SCMI_PROTOCOL=y
> > CONFIG_ARM_SCPI_PROTOCOL=y
> > CONFIG_RASPBERRYPI_FIRMWARE=y
> > @@ -405,6 +406,9 @@ CONFIG_MWIFIEX_SDIO=m
> > CONFIG_MWIFIEX_PCIE=m
> > CONFIG_WL18XX=m
> > CONFIG_WLCORE_SDIO=m
> > +CONFIG_WWAN=m
> > +CONFIG_MHI_WWAN_CTRL=m
> > +CONFIG_MHI_WWAN_MBIM=m
>
> wondering if it could make sense to also enable CONFIG_MHI_NET, since
> in mhi_pci_generic there are also modems bound to that driver and, if
> not enabled, those would show just the control device, but not the
> netdevice.
Yes, indeed, that's a good idea. I had it enabled in my local config but
didn't include it as it isn't needed for the two machines I'm currently
working on.
I'll send a v2. Thanks!
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-15 17:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-14 16:22 [PATCH] arm64: defconfig: enable Qualcomm PCIe modem drivers Johan Hovold
2023-01-15 4:25 ` Manivannan Sadhasivam
2023-01-15 12:11 ` Daniele Palmas
2023-01-15 17:42 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox