public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] erofs: get rid of debug_one_dentry()
@ 2023-01-14 12:57 Gao Xiang
  2023-01-14 12:57 ` [PATCH 2/2] erofs: simplify iloc() Gao Xiang
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Gao Xiang @ 2023-01-14 12:57 UTC (permalink / raw)
  To: linux-erofs, Chao Yu, Yue Hu, Jingbo Xu; +Cc: LKML, Gao Xiang

From: Gao Xiang <hsiangkao@linux.alibaba.com>

Since erofsdump is available, no need to keep this debugging
functionality at all.

Also drop a useless comment since it's the VFS behavior.

Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
---
 fs/erofs/dir.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/fs/erofs/dir.c b/fs/erofs/dir.c
index ecf28f66b97d..6970b09b8307 100644
--- a/fs/erofs/dir.c
+++ b/fs/erofs/dir.c
@@ -6,21 +6,6 @@
  */
 #include "internal.h"
 
-static void debug_one_dentry(unsigned char d_type, const char *de_name,
-			     unsigned int de_namelen)
-{
-#ifdef CONFIG_EROFS_FS_DEBUG
-	/* since the on-disk name could not have the trailing '\0' */
-	unsigned char dbg_namebuf[EROFS_NAME_LEN + 1];
-
-	memcpy(dbg_namebuf, de_name, de_namelen);
-	dbg_namebuf[de_namelen] = '\0';
-
-	erofs_dbg("found dirent %s de_len %u d_type %d", dbg_namebuf,
-		  de_namelen, d_type);
-#endif
-}
-
 static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,
 			       void *dentry_blk, struct erofs_dirent *de,
 			       unsigned int nameoff, unsigned int maxsize)
@@ -52,10 +37,8 @@ static int erofs_fill_dentries(struct inode *dir, struct dir_context *ctx,
 			return -EFSCORRUPTED;
 		}
 
-		debug_one_dentry(d_type, de_name, de_namelen);
 		if (!dir_emit(ctx, de_name, de_namelen,
 			      le64_to_cpu(de->nid), d_type))
-			/* stopped by some reason */
 			return 1;
 		++de;
 		ctx->pos += sizeof(struct erofs_dirent);
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-02-14 13:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-14 12:57 [PATCH 1/2] erofs: get rid of debug_one_dentry() Gao Xiang
2023-01-14 12:57 ` [PATCH 2/2] erofs: simplify iloc() Gao Xiang
2023-01-14 14:46   ` kernel test robot
2023-01-14 15:08   ` [PATCH v2 " Gao Xiang
2023-01-16  1:52     ` Yue Hu
2023-01-16  2:22     ` Jingbo Xu
2023-02-14 13:44     ` Chao Yu
2023-01-16  2:24 ` [PATCH 1/2] erofs: get rid of debug_one_dentry() Jingbo Xu
2023-01-16  2:47 ` Yue Hu
2023-02-14 13:40 ` Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox