From: Jon Hunter <jonathanh@nvidia.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-tegra@vger.kernel.org>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
Jon Hunter <jonathanh@nvidia.com>
Subject: [PATCH V2 2/2] usb: gadget: u_ether: Don't warn in gether_setup_name_default()
Date: Mon, 16 Jan 2023 15:55:45 +0000 [thread overview]
Message-ID: <20230116155545.101391-2-jonathanh@nvidia.com> (raw)
In-Reply-To: <20230116155545.101391-1-jonathanh@nvidia.com>
The function gether_setup_name_default() is called by various USB
ethernet gadget drivers. This function always generates the MAC address
for the ethernet gadget device and always prints a warning when
generating the MAC address. Given that these messages are expected, make
these debug prints instead of warnings.
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
V1 -> V2: Changed print to debug instead of info.
drivers/usb/gadget/function/u_ether.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/u_ether.c b/drivers/usb/gadget/function/u_ether.c
index be8e7b448933..8feb40e38137 100644
--- a/drivers/usb/gadget/function/u_ether.c
+++ b/drivers/usb/gadget/function/u_ether.c
@@ -845,13 +845,13 @@ struct net_device *gether_setup_name_default(const char *netname)
snprintf(net->name, sizeof(net->name), "%s%%d", netname);
eth_random_addr(dev->dev_mac);
- pr_warn("using random self ethernet address %pM\n", dev->dev_mac);
+ pr_debug("using random self ethernet address %pM\n", dev->dev_mac);
/* by default we always have a random MAC address */
net->addr_assign_type = NET_ADDR_RANDOM;
eth_random_addr(dev->host_mac);
- pr_warn("using random host ethernet address %pM\n", dev->host_mac);
+ pr_debug("using random host ethernet address %pM\n", dev->host_mac);
net->netdev_ops = ð_netdev_ops;
--
2.25.1
next prev parent reply other threads:[~2023-01-16 15:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 15:55 [PATCH V2 1/2] usb: gadget: u_ether: Improve print in gether_setup_name_default() Jon Hunter
2023-01-16 15:55 ` Jon Hunter [this message]
2023-01-17 14:13 ` [PATCH V2 2/2] usb: gadget: u_ether: Don't warn " Andrzej Pietrasiewicz
2023-01-17 14:38 ` Andrzej Pietrasiewicz
2023-01-17 14:12 ` [PATCH V2 1/2] usb: gadget: u_ether: Improve print " Andrzej Pietrasiewicz
2023-01-17 15:04 ` Greg Kroah-Hartman
2023-01-19 10:14 ` Jon Hunter
2023-01-19 10:43 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116155545.101391-2-jonathanh@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=andrzej.p@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox