From: Richard Acayan <mailingradian@gmail.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Emil Velikov <emil.l.velikov@gmail.com>,
Vinay Simha BN <simhavcs@gmail.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Daniel Mentz <danielmentz@google.com>,
Caleb Connolly <caleb@connolly.tech>,
Neil Armstrong <neil.armstrong@linaro.org>,
Richard Acayan <mailingradian@gmail.com>
Subject: [RFC PATCH v3 3/3] drm/panel: vtdr6130: Use 16-bit brightness function
Date: Mon, 16 Jan 2023 17:49:09 -0500 [thread overview]
Message-ID: <20230116224909.23884-4-mailingradian@gmail.com> (raw)
In-Reply-To: <20230116224909.23884-1-mailingradian@gmail.com>
This panel communicates brightness in big endian. This is not a quirk of
the panels themselves, but rather, a part of the MIPI standard. Use the
new mipi_dsi_dcs_set_display_brightness_large() function that properly
handles 16-bit brightness instead of bypassing the brightness functions
entirely.
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
---
drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
index f9a6abc1e121..1092075b31a5 100644
--- a/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
+++ b/drivers/gpu/drm/panel/panel-visionox-vtdr6130.c
@@ -243,12 +243,9 @@ static int visionox_vtdr6130_bl_update_status(struct backlight_device *bl)
{
struct mipi_dsi_device *dsi = bl_get_data(bl);
u16 brightness = backlight_get_brightness(bl);
- /* Panel needs big-endian order of brightness value */
- u8 payload[2] = { brightness >> 8, brightness & 0xff };
int ret;
- ret = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS,
- payload, sizeof(payload));
+ mipi_dsi_dcs_set_display_brightness_large(dsi, brightness);
if (ret < 0)
return ret;
--
2.39.0
next prev parent reply other threads:[~2023-01-16 22:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 22:49 [RFC PATCH v3 0/3] drm/mipi-dsi: 16-bit Brightness Endianness Fix Richard Acayan
2023-01-16 22:49 ` [RFC PATCH v3 1/3] drm/mipi-dsi: Fix byte order of 16-bit DCS set/get brightness Richard Acayan
2023-01-18 9:45 ` Neil Armstrong
2023-01-16 22:49 ` [RFC PATCH v3 2/3] drm/panel: sofef00: Use 16-bit brightness function Richard Acayan
2023-01-18 9:46 ` Neil Armstrong
2023-01-16 22:49 ` Richard Acayan [this message]
2023-01-18 9:45 ` [RFC PATCH v3 3/3] drm/panel: vtdr6130: " Neil Armstrong
2023-01-19 7:14 ` [RFC PATCH v3 0/3] drm/mipi-dsi: 16-bit Brightness Endianness Fix Sam Ravnborg
2023-01-19 7:24 ` Neil Armstrong
2023-01-19 7:24 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116224909.23884-4-mailingradian@gmail.com \
--to=mailingradian@gmail.com \
--cc=airlied@gmail.com \
--cc=caleb@connolly.tech \
--cc=daniel@ffwll.ch \
--cc=danielmentz@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sam@ravnborg.org \
--cc=simhavcs@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox