From: Arnd Bergmann <arnd@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Lai Jiangshan" <jiangshanlai@gmail.com>,
"Richard Clark" <richard.xnu.clark@gmail.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Andrey Grodzovsky" <andrey.grodzovsky@amd.com>,
"Tetsuo Handa" <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org
Subject: [PATCH] workqueue: fix enum type for gcc-13
Date: Tue, 17 Jan 2023 17:40:35 +0100 [thread overview]
Message-ID: <20230117164041.1207412-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
In gcc-13, the WORK_STRUCT_WQ_DATA_MASK constant is a signed 64-bit
type on 32-bit architectures because the enum definition has both
negative numbers and numbers above LONG_MAX in it:
kernel/workqueue.c: In function 'get_work_pwq':
kernel/workqueue.c:709:24: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
709 | return (void *)(data & WORK_STRUCT_WQ_DATA_MASK);
| ^
kernel/workqueue.c: In function 'get_work_pool':
kernel/workqueue.c:737:25: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
737 | return ((struct pool_workqueue *)
| ^
kernel/workqueue.c: In function 'get_work_pool_id':
kernel/workqueue.c:759:25: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
759 | return ((struct pool_workqueue *)
| ^
Change the enum definition to ensure all values can fit into
the range of 'unsigned long' on all architectures.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/linux/workqueue.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index ac551b8ee7d9..fba8d0154a1e 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -83,7 +83,7 @@ enum {
/* convenience constants */
WORK_STRUCT_FLAG_MASK = (1UL << WORK_STRUCT_FLAG_BITS) - 1,
- WORK_STRUCT_WQ_DATA_MASK = ~WORK_STRUCT_FLAG_MASK,
+ WORK_STRUCT_WQ_DATA_MASK = (unsigned long)~WORK_STRUCT_FLAG_MASK,
WORK_STRUCT_NO_POOL = (unsigned long)WORK_OFFQ_POOL_NONE << WORK_OFFQ_POOL_SHIFT,
/* bit mask for work_busy() return values */
--
2.39.0
next reply other threads:[~2023-01-17 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 16:40 Arnd Bergmann [this message]
2023-01-18 9:31 ` [PATCH] workqueue: fix enum type for gcc-13 David Laight
2023-01-18 16:38 ` Tejun Heo
2023-01-18 20:32 ` Arnd Bergmann
2023-01-19 1:41 ` Tejun Heo
2023-01-19 9:21 ` David Laight
2023-05-08 15:23 ` Thierry Reding
2023-05-09 3:26 ` Lai Jiangshan
2023-05-21 2:40 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230117164041.1207412-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=andrey.grodzovsky@amd.com \
--cc=arnd@arndb.de \
--cc=j.neuschaefer@gmx.net \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=richard.xnu.clark@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox