From: <yang.yang29@zte.com.cn>
To: <johannes@sipsolutions.net>
Cc: <kvalo@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<kuba@kernel.org>, <pabeni@redhat.com>,
<akpm@linux-foundation.org>, <songmuchun@bytedance.com>,
<brauner@kernel.org>, <julia.lawall@inria.fr>,
<gustavoars@kernel.org>, <jason@zx2c4.com>,
<linux-wireless@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <xu.panda@zte.com.cn>
Subject: Re: [PATCH net-next] wifi: airo: use strscpy() to instead of strncpy()
Date: Wed, 18 Jan 2023 10:22:19 +0800 (CST) [thread overview]
Message-ID: <202301181022195938376@zte.com.cn> (raw)
In-Reply-To: <a81cb8cd088e715936895ec6bb07cfdc8fec37c1.camel@sipsolutions.net>
> Again, why bother. But is this even correct/identical behaviour?>>
> Wouldn't it potentially read 17 input bytes before forcing NUL-
> termination?
Thank you for your reminder. This is a terrible error. Strscpy() may
cause the array to be out of bounds. I should be more cautious
next time.
Xu and Yang
prev parent reply other threads:[~2023-01-18 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 2:52 [PATCH net-next] wifi: airo: use strscpy() to instead of strncpy() yang.yang29
2023-01-17 21:27 ` Johannes Berg
2023-01-18 2:22 ` yang.yang29 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301181022195938376@zte.com.cn \
--to=yang.yang29@zte.com.cn \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavoars@kernel.org \
--cc=jason@zx2c4.com \
--cc=johannes@sipsolutions.net \
--cc=julia.lawall@inria.fr \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=songmuchun@bytedance.com \
--cc=xu.panda@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox