From: Arnd Bergmann <arnd@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Andreas Pape <apape@de.adit-jv.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] ASoC: pxa: remove snd_dmaengine_pcm_open_request_chan()
Date: Wed, 18 Jan 2023 17:10:46 +0100 [thread overview]
Message-ID: <20230118161110.521504-2-arnd@kernel.org> (raw)
In-Reply-To: <20230118161110.521504-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
The last caller was removed, so there is no longer a need for
this function.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
include/sound/dmaengine_pcm.h | 2 --
sound/core/pcm_dmaengine.c | 21 ---------------------
2 files changed, 23 deletions(-)
diff --git a/include/sound/dmaengine_pcm.h b/include/sound/dmaengine_pcm.h
index 2df54cf02cb3..a497d1f81cab 100644
--- a/include/sound/dmaengine_pcm.h
+++ b/include/sound/dmaengine_pcm.h
@@ -37,8 +37,6 @@ int snd_dmaengine_pcm_open(struct snd_pcm_substream *substream,
struct dma_chan *chan);
int snd_dmaengine_pcm_close(struct snd_pcm_substream *substream);
-int snd_dmaengine_pcm_open_request_chan(struct snd_pcm_substream *substream,
- dma_filter_fn filter_fn, void *filter_data);
int snd_dmaengine_pcm_close_release_chan(struct snd_pcm_substream *substream);
struct dma_chan *snd_dmaengine_pcm_request_channel(dma_filter_fn filter_fn,
diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c
index 494ec0c207fa..9f4120f020d8 100644
--- a/sound/core/pcm_dmaengine.c
+++ b/sound/core/pcm_dmaengine.c
@@ -328,27 +328,6 @@ int snd_dmaengine_pcm_open(struct snd_pcm_substream *substream,
}
EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_open);
-/**
- * snd_dmaengine_pcm_open_request_chan - Open a dmaengine based PCM substream and request channel
- * @substream: PCM substream
- * @filter_fn: Filter function used to request the DMA channel
- * @filter_data: Data passed to the DMA filter function
- *
- * This function will request a DMA channel using the passed filter function and
- * data. The function should usually be called from the pcm open callback. Note
- * that this function will use private_data field of the substream's runtime. So
- * it is not available to your pcm driver implementation.
- *
- * Return: 0 on success, a negative error code otherwise
- */
-int snd_dmaengine_pcm_open_request_chan(struct snd_pcm_substream *substream,
- dma_filter_fn filter_fn, void *filter_data)
-{
- return snd_dmaengine_pcm_open(substream,
- snd_dmaengine_pcm_request_channel(filter_fn, filter_data));
-}
-EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_open_request_chan);
-
/**
* snd_dmaengine_pcm_close - Close a dmaengine based PCM substream
* @substream: PCM substream
--
2.39.0
next prev parent reply other threads:[~2023-01-18 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:10 [PATCH 1/5] ASoC: samsung: remove DMA filter function and data Arnd Bergmann
2023-01-18 16:10 ` Arnd Bergmann [this message]
2023-01-19 16:56 ` [PATCH 2/5] ASoC: pxa: remove snd_dmaengine_pcm_open_request_chan() Mark Brown
2023-01-18 16:10 ` [PATCH 3/5] ASoC: ux500: remove platform_data support Arnd Bergmann
2023-01-18 22:32 ` Linus Walleij
2023-01-18 16:10 ` [PATCH 4/5] ASoC: ux500: remove stedma40 references Arnd Bergmann
2023-01-18 22:34 ` Linus Walleij
2023-01-18 16:10 ` [PATCH 5/5] ASoC: remove snd_dmaengine_pcm_config->compat_request_channel Arnd Bergmann
2023-01-19 15:39 ` [PATCH 1/5] ASoC: samsung: remove DMA filter function and data Krzysztof Kozlowski
2023-01-19 16:59 ` Mark Brown
2023-01-20 9:05 ` Arnd Bergmann
2023-01-20 12:07 ` Mark Brown
2023-01-20 12:29 ` Arnd Bergmann
2023-01-20 22:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118161110.521504-2-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=apape@de.adit-jv.com \
--cc=arnd@arndb.de \
--cc=erosca@de.adit-jv.com \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox