From: "Eugenio Pérez" <eperezma@redhat.com>
To: mst@redhat.com
Cc: leiyang@redhat.com, Laurent Vivier <lvivier@redhat.com>,
sgarzare@redhat.com, jasowang@redhat.com,
Zhu Lingshan <lingshan.zhu@intel.com>,
virtualization@lists.linux-foundation.org, si-wei.liu@oracle.com,
linux-kernel@vger.kernel.org, lulu@redhat.com,
Gautam Dawar <gdawar@xilinx.com>,
alvaro.karsz@solid-run.com
Subject: [PATCH 1/2] vdpa_sim: not reset state in vdpasim_queue_ready
Date: Wed, 18 Jan 2023 17:43:58 +0100 [thread overview]
Message-ID: <20230118164359.1523760-2-eperezma@redhat.com> (raw)
In-Reply-To: <20230118164359.1523760-1-eperezma@redhat.com>
vdpasim_queue_ready calls vringh_init_iotlb, which resets split indexes.
But it can be called after setting a ring base with
vdpasim_set_vq_state.
Fix it by stashing them. They're still resetted in vdpasim_vq_reset.
This was discovered and tested live migrating the vdpa_sim_net device.
Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index cb88891b44a8..8839232a3fcb 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -66,6 +66,7 @@ static void vdpasim_vq_notify(struct vringh *vring)
static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
{
struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
+ uint16_t last_avail_idx = vq->vring.last_avail_idx;
vringh_init_iotlb(&vq->vring, vdpasim->features, vq->num, false,
(struct vring_desc *)(uintptr_t)vq->desc_addr,
@@ -74,6 +75,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
(struct vring_used *)
(uintptr_t)vq->device_addr);
+ vq->vring.last_avail_idx = last_avail_idx;
vq->vring.notify = vdpasim_vq_notify;
}
--
2.31.1
next prev parent reply other threads:[~2023-01-18 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:43 [PATCH 0/2] Fix expected set_vq_state behavior on vdpa_sim Eugenio Pérez
2023-01-18 16:43 ` Eugenio Pérez [this message]
2023-01-19 3:16 ` [PATCH 1/2] vdpa_sim: not reset state in vdpasim_queue_ready Jason Wang
2023-01-19 9:14 ` Eugenio Perez Martin
2023-01-29 5:56 ` Jason Wang
2023-01-31 15:44 ` Lei Yang
2023-01-18 16:43 ` [PATCH 2/2] vringh: fetch used_idx from vring at vringh_init_iotlb Eugenio Pérez
2023-01-19 3:20 ` Jason Wang
2023-01-19 8:10 ` Eugenio Perez Martin
2023-01-29 6:00 ` Jason Wang
2023-01-30 16:38 ` Eugenio Perez Martin
2023-01-31 3:16 ` Jason Wang
2023-01-31 7:58 ` Eugenio Perez Martin
2023-02-13 12:03 ` Michael S. Tsirkin
2023-02-01 16:11 ` Michael S. Tsirkin
2023-02-01 17:24 ` Eugenio Perez Martin
2023-01-27 10:53 ` [PATCH 0/2] Fix expected set_vq_state behavior on vdpa_sim Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230118164359.1523760-2-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=gdawar@xilinx.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox