Re: [kbd] [patch] font: Leverage KD_FONT_OP_GET/SET_TALL font operations

Samuel Thibault
2023-01-16T22:44:42Z

Alexey Gladkov, le mer. 11 janv. 2023 21:00:05 +0100, a ecrit:
> > @@ -54,13 +55,13 @@ do_loadfont(struct kfont_context *ctx, i
> > int bad_video_erase_char = 0;
> > int ret;
> >
> > - if (height < 1 || height > 32) {
> > - KFONT_ERR(ctx, _("Bad character height %d"), height);
> > + if (height < 1 || height > 64) {
> > + KFONT_ERR(ctx, _("Bad character height %d (limit is 64)"), height);
>
> Hm. But max_font_height is 128. Shouldn't it be height > 128 ?
>
> > return -EX_DATAERR;
> > }
> >
> > - if (width < 1 || width > 32) {
> > - KFONT_ERR(ctx, _("Bad character width %d"), width);
> > + if (width < 1 || width > 128) {
> > + KFONT_ERR(ctx, _("Bad character width %d (limit is 128)"), width);
>
> Same here. max_font_width is 64.

Oops, sure, fixed it, will send an updated kbd patch for that.

Samuel