From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/5] usb: fotg210-udc: remove redundant error logging
Date: Fri, 20 Jan 2023 17:44:35 +0200 [thread overview]
Message-ID: <20230120154437.22025-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230120154437.22025-1-andriy.shevchenko@linux.intel.com>
A call to platform_get_irq() already prints an error on failure within
its own implementation. So printing another error based on its return
value in the caller is redundant and should be removed. The clean up
also makes if condition block braces unnecessary. Remove that as well.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/usb/fotg210/fotg210-udc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/fotg210/fotg210-udc.c b/drivers/usb/fotg210/fotg210-udc.c
index 4334504fccc8..18d254125186 100644
--- a/drivers/usb/fotg210/fotg210-udc.c
+++ b/drivers/usb/fotg210/fotg210-udc.c
@@ -1169,10 +1169,8 @@ int fotg210_udc_probe(struct platform_device *pdev, struct fotg210 *fotg)
int i;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- pr_err("could not get irq\n");
- return -ENODEV;
- }
+ if (irq < 0)
+ return irq;
/* initialize udc */
fotg210 = kzalloc(sizeof(struct fotg210_udc), GFP_KERNEL);
--
2.39.0
next prev parent reply other threads:[~2023-01-20 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 15:44 [PATCH v1 1/5] usb: fotg210-hcd: use sysfs_emit() to instead of scnprintf() Andy Shevchenko
2023-01-20 15:44 ` [PATCH v1 2/5] usb: fotg210-hcd: Don't shadow error codes in store() Andy Shevchenko
2023-01-26 20:00 ` Linus Walleij
2023-01-20 15:44 ` Andy Shevchenko [this message]
2023-01-26 20:01 ` [PATCH v1 3/5] usb: fotg210-udc: remove redundant error logging Linus Walleij
2023-01-20 15:44 ` [PATCH v1 4/5] usb: fotg210: Switch to use dev_err_probe() Andy Shevchenko
2023-01-26 20:01 ` Linus Walleij
2023-02-16 8:07 ` Christophe JAILLET
2023-02-16 8:30 ` Linus Walleij
2023-01-20 15:44 ` [PATCH v1 5/5] usb: fotg210: use devm_platform_get_and_ioremap_resource() Andy Shevchenko
2023-01-26 20:02 ` Linus Walleij
2023-01-27 8:55 ` Andy Shevchenko
2023-01-27 9:10 ` Linus Walleij
2023-01-27 9:16 ` Andy Shevchenko
2023-01-26 19:59 ` [PATCH v1 1/5] usb: fotg210-hcd: use sysfs_emit() to instead of scnprintf() Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120154437.22025-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox