Re: [PATCH v3 3/9] arm64: dts: amlogic: Used onboard usb hub reset on odroid c2

Krzysztof Kozlowski
2023-08-05T21:30:30Z

On 02/08/2023 23:06, Ben Wolsieffer wrote:
> On Sat, Jan 21, 2023 at 05:56:31PM +0000, Anand Moon wrote:
>> On Odroid c2 previously use gpio-hog to reset the usb hub,
>> switch to used on-board usb hub reset to enable the usb hub
>> and enable power to hub.
>>

...

>> + hub@1 {
>> + /* Genesys Logic GL852G USB 2.0 hub */
>> + compatible = "usb5e3,610";
>> + reg = <1>;
>> + vdd-supply = <&p5v0>;
>> + reset-gpio = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_LOW>;
>> + };
>> };
>> --
>> 2.38.1
>>
>
> Hello,
>
> This patch breaks USB support on the ODROID-C2. As soon as the
> onboard_usb_hub module is loaded, all USB devices disconnect.
> Blacklisting onboard_usb_hub makes USB work as expected.
>
> I tried to reproduce the problem by manually toggling the reset line,
> but the problem seems to be specific to this driver. When reset is
> asserted manually, the devices disconnect, but they all enumerate again
> as soon as reset is released.
>
> Also, I have been unable to make USB work again (until the next reboot)
> even after unloading onboard_usb_hub.

Wasn't this patch made exactly to fix USB support, not break it? I might
be missing something but maybe this was not tested at all?

Best regards,
Krzysztof