* [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands
@ 2023-01-25 8:57 Robert Richter
2023-01-25 10:29 ` Jonathan Cameron
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Robert Richter @ 2023-01-25 8:57 UTC (permalink / raw)
To: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams
Cc: Jonathan Cameron, Dave Jiang, Robert Richter, linux-cxl,
linux-kernel
Only unsupported mailbox commands are reported in debug messages. A
list of enabled commands is useful too. Change debug messages to also
report the opcodes of enabled commands. Esp. if card initialization
fails there is no way to get this information from userland.
On that occasion also add missing trailing newlines.
Signed-off-by: Robert Richter <rrichter@amd.com>
---
v2:
* Changed message to "Opcode 0x%04x enabled\n". Updated patch
description accordingly.
drivers/cxl/core/mbox.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index a48ade466d6a..202d49dd9911 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
if (!cmd) {
dev_dbg(cxlds->dev,
- "Opcode 0x%04x unsupported by driver", opcode);
+ "Opcode 0x%04x unsupported by driver\n", opcode);
continue;
}
set_bit(cmd->info.id, cxlds->enabled_cmds);
+ dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode);
}
}
base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands
2023-01-25 8:57 [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands Robert Richter
@ 2023-01-25 10:29 ` Jonathan Cameron
2023-01-25 15:52 ` Alison Schofield
2023-01-26 23:58 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2023-01-25 10:29 UTC (permalink / raw)
To: Robert Richter
Cc: Alison Schofield, Vishal Verma, Ira Weiny, Ben Widawsky,
Dan Williams, Dave Jiang, linux-cxl, linux-kernel
On Wed, 25 Jan 2023 09:57:28 +0100
Robert Richter <rrichter@amd.com> wrote:
> Only unsupported mailbox commands are reported in debug messages. A
> list of enabled commands is useful too. Change debug messages to also
> report the opcodes of enabled commands. Esp. if card initialization
> fails there is no way to get this information from userland.
>
> On that occasion also add missing trailing newlines.
>
> Signed-off-by: Robert Richter <rrichter@amd.com>
Fine with change in message
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> v2:
> * Changed message to "Opcode 0x%04x enabled\n". Updated patch
> description accordingly.
>
> drivers/cxl/core/mbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index a48ade466d6a..202d49dd9911 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
>
> if (!cmd) {
> dev_dbg(cxlds->dev,
> - "Opcode 0x%04x unsupported by driver", opcode);
> + "Opcode 0x%04x unsupported by driver\n", opcode);
> continue;
> }
>
> set_bit(cmd->info.id, cxlds->enabled_cmds);
> + dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode);
> }
> }
>
>
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands
2023-01-25 8:57 [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands Robert Richter
2023-01-25 10:29 ` Jonathan Cameron
@ 2023-01-25 15:52 ` Alison Schofield
2023-01-26 23:58 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Alison Schofield @ 2023-01-25 15:52 UTC (permalink / raw)
To: Robert Richter
Cc: Vishal Verma, Ira Weiny, Ben Widawsky, Dan Williams,
Jonathan Cameron, Dave Jiang, linux-cxl, linux-kernel
On Wed, Jan 25, 2023 at 09:57:28AM +0100, Robert Richter wrote:
> Only unsupported mailbox commands are reported in debug messages. A
> list of enabled commands is useful too. Change debug messages to also
> report the opcodes of enabled commands. Esp. if card initialization
> fails there is no way to get this information from userland.
>
> On that occasion also add missing trailing newlines.
>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
> v2:
> * Changed message to "Opcode 0x%04x enabled\n". Updated patch
> description accordingly.
Thanks Robert,
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
>
> drivers/cxl/core/mbox.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index a48ade466d6a..202d49dd9911 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel)
>
> if (!cmd) {
> dev_dbg(cxlds->dev,
> - "Opcode 0x%04x unsupported by driver", opcode);
> + "Opcode 0x%04x unsupported by driver\n", opcode);
> continue;
> }
>
> set_bit(cmd->info.id, cxlds->enabled_cmds);
> + dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode);
> }
> }
>
>
> base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands
2023-01-25 8:57 [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands Robert Richter
2023-01-25 10:29 ` Jonathan Cameron
2023-01-25 15:52 ` Alison Schofield
@ 2023-01-26 23:58 ` Dan Williams
2 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2023-01-26 23:58 UTC (permalink / raw)
To: Robert Richter, Alison Schofield, Vishal Verma, Ira Weiny,
Ben Widawsky, Dan Williams
Cc: Jonathan Cameron, Dave Jiang, Robert Richter, linux-cxl,
linux-kernel
Robert Richter wrote:
> Only unsupported mailbox commands are reported in debug messages. A
> list of enabled commands is useful too. Change debug messages to also
> report the opcodes of enabled commands. Esp. if card initialization
> fails there is no way to get this information from userland.
>
> On that occasion also add missing trailing newlines.
>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> ---
> v2:
> * Changed message to "Opcode 0x%04x enabled\n". Updated patch
> description accordingly.
Thanks Robert, replaced v1 with v2 in my tree. Should show up on
cxl/pending shortly.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-26 23:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-25 8:57 [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands Robert Richter
2023-01-25 10:29 ` Jonathan Cameron
2023-01-25 15:52 ` Alison Schofield
2023-01-26 23:58 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox