From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: leiyang@redhat.com, Laurent Vivier <lvivier@redhat.com>,
sgarzare@redhat.com, jasowang@redhat.com,
Zhu Lingshan <lingshan.zhu@intel.com>,
virtualization@lists.linux-foundation.org, si-wei.liu@oracle.com,
linux-kernel@vger.kernel.org, lulu@redhat.com,
Gautam Dawar <gdawar@xilinx.com>,
alvaro.karsz@solid-run.com
Subject: Re: [PATCH 0/2] Fix expected set_vq_state behavior on vdpa_sim
Date: Fri, 27 Jan 2023 05:53:36 -0500 [thread overview]
Message-ID: <20230127055303-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230118164359.1523760-1-eperezma@redhat.com>
On Wed, Jan 18, 2023 at 05:43:57PM +0100, Eugenio Pérez wrote:
> The use of set_vq_state is to indicate vdpa device the state of a virtqueue.
> In the case of split, it means the avail_idx. This is mandatory for use
> cases like live migration.
>
> However, vdpa_sim reset the vq state at vdpasim_queue_ready since it calls
> vringh_init_iotlb.
>
> Also, to starting from an used_idx different than 0 is needed in use cases like
> virtual machine migration. Not doing so and letting the caller set an avail
> idx different than 0 causes destination device to try to use old buffers that
> source driver already recover and are not available anymore.
>
> This series fixes both problems allowing to migrate to a vdpa_sim_net device.
Jason problems you pointed out are all consmetic do you ack
the patchset? Or expect another revision?
> Eugenio Pérez (2):
> vdpa_sim: not reset state in vdpasim_queue_ready
> vringh: fetch used_idx from vring at vringh_init_iotlb
>
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 ++
> drivers/vhost/vringh.c | 25 +++++++++++++++++++++++--
> 2 files changed, 25 insertions(+), 2 deletions(-)
>
> --
> 2.31.1
>
prev parent reply other threads:[~2023-01-27 10:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 16:43 [PATCH 0/2] Fix expected set_vq_state behavior on vdpa_sim Eugenio Pérez
2023-01-18 16:43 ` [PATCH 1/2] vdpa_sim: not reset state in vdpasim_queue_ready Eugenio Pérez
2023-01-19 3:16 ` Jason Wang
2023-01-19 9:14 ` Eugenio Perez Martin
2023-01-29 5:56 ` Jason Wang
2023-01-31 15:44 ` Lei Yang
2023-01-18 16:43 ` [PATCH 2/2] vringh: fetch used_idx from vring at vringh_init_iotlb Eugenio Pérez
2023-01-19 3:20 ` Jason Wang
2023-01-19 8:10 ` Eugenio Perez Martin
2023-01-29 6:00 ` Jason Wang
2023-01-30 16:38 ` Eugenio Perez Martin
2023-01-31 3:16 ` Jason Wang
2023-01-31 7:58 ` Eugenio Perez Martin
2023-02-13 12:03 ` Michael S. Tsirkin
2023-02-01 16:11 ` Michael S. Tsirkin
2023-02-01 17:24 ` Eugenio Perez Martin
2023-01-27 10:53 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127055303-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox