From: Mario Limonciello <mario.limonciello@amd.com>
To: Jaroslav Kysela <jkysela@redhat.com>,
Mukunda Vijendar <Vijendar.Mukunda@amd.com>,
Saba Kareem Syed <Syed.SabaKareem@amd.com>,
<linux-kernel@vger.kernel.org>
Cc: Pananchikkal Renjith <Renjith.Pananchikkal@amd.com>,
Mark Pearson <mpearson@lenovo.com>,
Mario Limonciello <mario.limonciello@amd.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>
Subject: [PATCH 3/6] ASoC: amd: renoir: Adjust the gain for PDM DMIC
Date: Fri, 27 Jan 2023 10:01:30 -0600 [thread overview]
Message-ID: <20230127160134.2658-4-mario.limonciello@amd.com> (raw)
In-Reply-To: <20230127160134.2658-1-mario.limonciello@amd.com>
A similar issue that was reported on Rembrandt based laptops with
low DMIC volume is also being reported for Barcelo based laptops
that use renoir acp3x.
Increase the PDM gain to overcome this problem.
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
sound/soc/amd/renoir/rn_acp3x.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/renoir/rn_acp3x.h b/sound/soc/amd/renoir/rn_acp3x.h
index ca586603d7203..c174f84650d24 100644
--- a/sound/soc/amd/renoir/rn_acp3x.h
+++ b/sound/soc/amd/renoir/rn_acp3x.h
@@ -34,7 +34,7 @@
#define ACP_ERROR_STAT 29
#define PDM_DECIMATION_FACTOR 0x2
#define ACP_PDM_CLK_FREQ_MASK 0x07
-#define ACP_WOV_MISC_CTRL_MASK 0x10
+#define ACP_WOV_MISC_CTRL_MASK 0x18
#define ACP_PDM_ENABLE 0x01
#define ACP_PDM_DISABLE 0x00
#define ACP_PDM_DMA_EN_STATUS 0x02
--
2.34.1
next prev parent reply other threads:[~2023-01-27 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 16:01 [PATCH 0/6] Fix default DMIC gain on AMD PDM drivers Mario Limonciello
2023-01-27 16:01 ` [PATCH 1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-27 16:53 ` Mark Brown
2023-01-27 17:02 ` Limonciello, Mario
2023-01-27 16:01 ` [PATCH 2/6] ASoC: amd: yc: Add a module parameter to influence pdm_gain Mario Limonciello
2023-01-27 16:23 ` Jaroslav Kysela
2023-01-27 16:25 ` Limonciello, Mario
2023-01-27 16:41 ` Jaroslav Kysela
2023-01-27 16:55 ` Mark Brown
2023-01-27 16:01 ` Mario Limonciello [this message]
2023-01-27 16:01 ` [PATCH 4/6] ASoC: amd: renoir: " Mario Limonciello
2023-01-27 16:01 ` [PATCH 5/6] ASoC: amd: ps: Adjust the gain for PDM DMIC Mario Limonciello
2023-01-27 16:01 ` [PATCH 6/6] ASoC: amd: ps: Add a module parameter to influence pdm_gain Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127160134.2658-4-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Renjith.Pananchikkal@amd.com \
--cc=Syed.SabaKareem@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jkysela@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpearson@lenovo.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox