From: Manivannan Sadhasivam <mani@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: "James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Bart Van Assche <bvanassche@acm.org>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Can Guo <quic_cang@quicinc.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: include specific ops when GENERIC_MSI_IRQ is set
Date: Mon, 30 Jan 2023 13:55:06 +0530 [thread overview]
Message-ID: <20230130082506.GC12687@thinkpad> (raw)
In-Reply-To: <20230130075615.17108-1-lukas.bulwahn@gmail.com>
On Mon, Jan 30, 2023 at 08:56:15AM +0100, Lukas Bulwahn wrote:
> Commit 13e7accb81d6 ("genirq: Get rid of GENERIC_MSI_IRQ_DOMAIN") removes
> the config GENERIC_MSI_IRQ_DOMAIN and replaces all references with
> GENERIC_MSI_IRQ.
>
> Probably due to concurrent development, commit 519b6274a777 ("scsi: ufs:
> qcom: Add MCQ ESI config vendor specific ops") adds an ifdef block
> conditional under the config GENERIC_MSI_IRQ_DOMAIN.
>
> Make this code conditional under the existing config GENERIC_MSI_IRQ.
>
> Fixes: 519b6274a777 ("scsi: ufs: qcom: Add MCQ ESI config vendor specific ops")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
There is already a patch submitted for fixing this issue:
https://lore.kernel.org/linux-scsi/20230126211831.2274211-1-arnd@kernel.org/
Thanks,
Mani
> ---
> drivers/ufs/host/ufs-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 681da3ea7154..14283f6dc3f7 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1538,7 +1538,7 @@ static int ufs_qcom_get_outstanding_cqs(struct ufs_hba *hba,
> return 0;
> }
>
> -#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
> +#ifdef CONFIG_GENERIC_MSI_IRQ
> static void ufs_qcom_write_msi_msg(struct msi_desc *desc, struct msi_msg *msg)
> {
> struct device *dev = msi_desc_to_dev(desc);
> --
> 2.17.1
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-01-30 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 7:56 [PATCH] scsi: ufs: qcom: include specific ops when GENERIC_MSI_IRQ is set Lukas Bulwahn
2023-01-30 8:25 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130082506.GC12687@thinkpad \
--to=mani@kernel.org \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox