From: Chris Healy <cphealy@gmail.com>
To: cphealy@gmail.com, andrew@lunn.ch, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net,
neil.armstrong@linaro.org, khilman@baylibre.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
jeremy.wang@amlogic.com
Cc: Chris Healy <healych@amazon.com>
Subject: [PATCH v3] net: phy: meson-gxl: Add generic dummy stubs for MMD register access
Date: Mon, 30 Jan 2023 15:14:02 -0800 [thread overview]
Message-ID: <20230130231402.471493-1-cphealy@gmail.com> (raw)
From: Chris Healy <healych@amazon.com>
The Meson G12A Internal PHY does not support standard IEEE MMD extended
register access, therefore add generic dummy stubs to fail the read and
write MMD calls. This is necessary to prevent the core PHY code from
erroneously believing that EEE is supported by this PHY even though this
PHY does not support EEE, as MMD register access returns all FFFFs.
Fixes: 5c3407abb338 ("net: phy: meson-gxl: add g12a support")
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Chris Healy <healych@amazon.com>
---
Changes in v3:
* Add reviewed-by
Change in v2:
* Add fixes tag
drivers/net/phy/meson-gxl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c49062ad72c6..5e41658b1e2f 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
.handle_interrupt = meson_gxl_handle_interrupt,
.suspend = genphy_suspend,
.resume = genphy_resume,
+ .read_mmd = genphy_read_mmd_unsupported,
+ .write_mmd = genphy_write_mmd_unsupported,
},
};
--
2.39.1
next reply other threads:[~2023-01-30 23:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 23:14 Chris Healy [this message]
2023-01-31 10:05 ` [PATCH v3] net: phy: meson-gxl: Add generic dummy stubs for MMD register access Jerome Brunet
2023-01-31 10:38 ` Heiner Kallweit
2023-01-31 10:59 ` Jerome Brunet
2023-01-31 12:08 ` Heiner Kallweit
2023-02-01 5:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130231402.471493-1-cphealy@gmail.com \
--to=cphealy@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=healych@amazon.com \
--cc=hkallweit1@gmail.com \
--cc=jeremy.wang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox