From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CFAC38142 for ; Tue, 31 Jan 2023 15:04:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232902AbjAaPEU (ORCPT ); Tue, 31 Jan 2023 10:04:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232556AbjAaPD5 (ORCPT ); Tue, 31 Jan 2023 10:03:57 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE49D56480; Tue, 31 Jan 2023 07:01:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CE97061546; Tue, 31 Jan 2023 15:01:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68AD2C433A0; Tue, 31 Jan 2023 15:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675177281; bh=tlnF0aRLL0OO7zq4zta9AHbWNC51A2Pqbf849c5B8pM=; h=From:To:Cc:Subject:Date:From; b=EDzpF5vu5stUgXt9I7PPQTXmf+ksWLii6N0c8ywlqo34rBaicBO17JOJ3ti5fktjX sK4cvfp+acmxGn9UPOaSv270UDi9CurzYsugjpomyKaCW4NBu/utbSQzUs4GVhVYjd VqCQIJc8O6h+qrDbqBdzSAnmmfdaPZ8GK1axGha02mR/L9zelW6gubRrPQ1Af2C3vg qeIwakJryKf2cnGW7AwDGc/zKBCEb1yquJZ4Qzw82X5JeeWsORMXpM5okVOIJmybvg d0vp+GE9mD69Yp5d1QhQ6raM+rK9rbOI6jVtSlrHGQ9o44Fihd6SgFUF1VJdJFhsAU DVtZhwxPRPcOA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Maurizio Lombardi , Christoph Hellwig , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 1/4] scsi: target: core: Fix warning on RT kernels Date: Tue, 31 Jan 2023 10:01:15 -0500 Message-Id: <20230131150118.1250409-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maurizio Lombardi [ Upstream commit 84ed64b1a7a7fcd507598dee7708c1f225123711 ] Calling spin_lock_irqsave() does not disable the interrupts on realtime kernels, remove the warning and replace assert_spin_locked() with lockdep_assert_held(). Signed-off-by: Maurizio Lombardi Reviewed-by: Christoph Hellwig Link: https://lore.kernel.org/r/20230110125310.55884-1-mlombard@redhat.com Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_tmr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c index 6d1179a7f043..bba24eaea2ce 100644 --- a/drivers/target/target_core_tmr.c +++ b/drivers/target/target_core_tmr.c @@ -95,8 +95,8 @@ static bool __target_check_io_state(struct se_cmd *se_cmd, { struct se_session *sess = se_cmd->se_sess; - assert_spin_locked(&sess->sess_cmd_lock); - WARN_ON_ONCE(!irqs_disabled()); + lockdep_assert_held(&sess->sess_cmd_lock); + /* * If command already reached CMD_T_COMPLETE state within * target_complete_cmd() or CMD_T_FABRIC_STOP due to shutdown, -- 2.39.0