Re: [PATCH v9 10/27] gunyah: rsc_mgr: Add VM lifecycle RPC

Elliot Berman
2023-01-30T21:43:50Z

On 1/24/2023 10:12 PM, Srivatsa Vaddagiri wrote:
> * Elliot Berman <quic_eberman@quicinc.com> [2023-01-20 14:46:09]:
>
>> +int gh_rm_vm_stop(struct gh_rm *rm, u16 vmid)
>> +{
>> + struct gh_vm_stop_req req_payload = {
>> + .vmid = cpu_to_le16(vmid),
>> + };
>> + void *resp;
>> + size_t resp_size;
>> + int ret;
>> +
>> + ret = gh_rm_call(rm, GH_RM_RPC_VM_STOP, &req_payload, sizeof(req_payload),
>> + &resp, &resp_size);
>
> Why not use gh_rm_common_vmid_call() here as well?
>
> return gh_rm_common_vmid_call(rm, GH_RM_RPC_VM_STOP, vmid);
>
>

gh_vm_stop_req isn't the same as the common payload.