Re: [PATCH v1 1/1] mei: Move uuid_le_cmp() to its only user

Andy Shevchenko
2023-02-02T15:36:38Z

On Thu, Feb 02, 2023 at 04:22:34PM +0100, Christoph Hellwig wrote:
> On Thu, Feb 02, 2023 at 05:21:52PM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 02, 2023 at 04:17:59PM +0100, Christoph Hellwig wrote:
> > > On Thu, Feb 02, 2023 at 04:54:12PM +0200, Andy Shevchenko wrote:
> > > > There is only a single user of uuid_le_cmp() API, let's make it private
> > > > to that user.
> > >
> > > Any reason this code can't just use guid_t and guid_equal?
> >
> > It's part of ABI, while guid_* are for the internal use.
> >
> > Eventually they may switch to the internal types, but it's up to MEI.
>
> How can a type name be part of a binary interface?

If I'm not mistaken there is a difference between simple __u8[16] and
struct { __u8[16] } due to alignment. But data wise it's the same, of
course. That said, it depends on how this type is being used in the
any of ABI.

From the API perspective the guid_* are not visible to uAPI.

--
With Best Regards,
Andy Shevchenko