public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 1/1] dmaengine: idma64: Update bytes_transferred field
@ 2023-02-03 12:17 aman.kumar
  2023-02-10  9:02 ` Vinod Koul
  0 siblings, 1 reply; 2+ messages in thread
From: aman.kumar @ 2023-02-03 12:17 UTC (permalink / raw)
  To: vkoul, dmaengine
  Cc: andriy.shevchenko, srikanth.thokala, aman.kumar,
	mallikarjunappa.sangannavar, linux-kernel

From: Aman Kumar <aman.kumar@intel.com>

Currently when 8250 data transfer is done, bytes_tranferred always returns
0 at /sys/devices/pci0000\:\:**.*/dma/dma*chan*/bytes_transferred.
In many cases it gives false impression that data is not being
trasferred via DMA.

So, updating the bytes_transferred field to count the bytes
whenever there is data transfer using idma64.

Co-developed-by: Srikanth Thokala <srikanth.thokala@intel.com>
Signed-off-by: Srikanth Thokala <srikanth.thokala@intel.com>
Signed-off-by: Aman Kumar <aman.kumar@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/dma/idma64.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index c33087c5cd02..8880d2b91bf5 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -137,8 +137,11 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
 		u32 status_err, u32 status_xfer)
 {
 	struct idma64_chan *idma64c = &idma64->chan[c];
+	struct dma_chan_percpu *stat;
 	struct idma64_desc *desc;
 
+	stat = this_cpu_ptr(idma64c->vchan.chan.local);
+
 	spin_lock(&idma64c->vchan.lock);
 	desc = idma64c->desc;
 	if (desc) {
@@ -149,6 +152,7 @@ static void idma64_chan_irq(struct idma64 *idma64, unsigned short c,
 			dma_writel(idma64, CLEAR(XFER), idma64c->mask);
 			desc->status = DMA_COMPLETE;
 			vchan_cookie_complete(&desc->vdesc);
+			stat->bytes_transferred += desc->length;
 			idma64_start_transfer(idma64c);
 		}
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] dmaengine: idma64: Update bytes_transferred field
  2023-02-03 12:17 [PATCH v1 1/1] dmaengine: idma64: Update bytes_transferred field aman.kumar
@ 2023-02-10  9:02 ` Vinod Koul
  0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2023-02-10  9:02 UTC (permalink / raw)
  To: aman.kumar
  Cc: dmaengine, andriy.shevchenko, srikanth.thokala,
	mallikarjunappa.sangannavar, linux-kernel

On 03-02-23, 17:47, aman.kumar@intel.com wrote:
> From: Aman Kumar <aman.kumar@intel.com>
> 
> Currently when 8250 data transfer is done, bytes_tranferred always returns
> 0 at /sys/devices/pci0000\:\:**.*/dma/dma*chan*/bytes_transferred.
> In many cases it gives false impression that data is not being
> trasferred via DMA.
> 
> So, updating the bytes_transferred field to count the bytes
> whenever there is data transfer using idma64.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-10  9:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-03 12:17 [PATCH v1 1/1] dmaengine: idma64: Update bytes_transferred field aman.kumar
2023-02-10  9:02 ` Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox