From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: Thomas Witt <kernel@witt.link>, Vidya Sagar <vidyas@nvidia.com>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 0/2] Revert ASPM L1 Substates updates
Date: Fri, 3 Feb 2023 16:48:18 -0600 [thread overview]
Message-ID: <20230203224820.2056582-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
Thomas Witt reported that 5e85eba6f50d ("PCI/ASPM: Refactor L1 PM
Substates Control Register programming") broke suspend/resume on a
Tuxedo Infinitybook S 14 v5, which seems to use a Clevo L140CU Mainboard.
See https://bugzilla.kernel.org/show_bug.cgi?id=216877
Since we haven't figured out a root cause, revert the relevant patches for
now.
Note that reverting "Save L1 PM Substates Capability for suspend/resume"
means machines will use more power after suspend/resume because the L1
Substates configuration is lost, but they should still work correctly.
Bjorn Helgaas (2):
Revert "PCI/ASPM: Save L1 PM Substates Capability for suspend/resume"
Revert "PCI/ASPM: Refactor L1 PM Substates Control Register
programming"
drivers/pci/pci.c | 7 ---
drivers/pci/pci.h | 4 --
drivers/pci/pcie/aspm.c | 109 ++++++++++++----------------------------
3 files changed, 33 insertions(+), 87 deletions(-)
--
2.25.1
next reply other threads:[~2023-02-03 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 22:48 Bjorn Helgaas [this message]
2023-02-03 22:48 ` [PATCH 1/2] Revert "PCI/ASPM: Save L1 PM Substates Capability for suspend/resume" Bjorn Helgaas
2023-02-03 22:48 ` [PATCH 2/2] Revert "PCI/ASPM: Refactor L1 PM Substates Control Register programming" Bjorn Helgaas
2023-02-04 17:45 ` Lukas Wunner
2023-02-04 20:48 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203224820.2056582-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=kernel@witt.link \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox