From: Davidlohr Bueso <dave@stgolabs.net>
To: John Stultz <jstultz@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Joel Fernandes <joel@joelfernandes.org>,
Juri Lelli <juri.lelli@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: Re: [PATCH v2 4/4] locktorture: With nested locks, occasionally skip main lock
Date: Sun, 5 Feb 2023 11:05:48 -0800 [thread overview]
Message-ID: <20230205190548.7auywdoagy6txpla@offworld> (raw)
In-Reply-To: <20230203200138.3872873-4-jstultz@google.com>
On Fri, 03 Feb 2023, John Stultz wrote:
>@@ -754,21 +755,28 @@ static int lock_torture_writer(void *arg)
> schedule_timeout_uninterruptible(1);
>
> lockset_mask = torture_random(&rand);
>+ skip_main_lock = nlocks && !(torture_random(&rand) % 100);
For the sake of future readers of locktorture.c, this deserves a comment
as to why we wanna skip the main lock (copy/paste from the changelog).
Thanks,
Davidlohr
next prev parent reply other threads:[~2023-02-05 19:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 20:01 [PATCH v2 1/4] locktorture: Add nested_[un]lock() hooks and nlocks parameter John Stultz
2023-02-03 20:01 ` [PATCH v2 2/4] locktorture: Add nested locking to mutex torture tests John Stultz
2023-02-05 19:07 ` Davidlohr Bueso
2023-02-06 17:20 ` Paul E. McKenney
2023-02-06 19:24 ` John Stultz
2023-02-03 20:01 ` [PATCH v2 3/4] locktorture: Add nested locking to rtmutex " John Stultz
2023-02-05 18:58 ` Davidlohr Bueso
2023-02-05 19:00 ` Davidlohr Bueso
2023-02-03 20:01 ` [PATCH v2 4/4] locktorture: With nested locks, occasionally skip main lock John Stultz
2023-02-05 19:05 ` Davidlohr Bueso [this message]
2023-02-06 20:37 ` John Stultz
2023-02-03 23:38 ` [PATCH v2 1/4] locktorture: Add nested_[un]lock() hooks and nlocks parameter Paul E. McKenney
2023-02-05 18:34 ` Davidlohr Bueso
2023-02-06 19:44 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230205190548.7auywdoagy6txpla@offworld \
--to=dave@stgolabs.net \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=jstultz@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox