From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
X86 ML <x86@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/kprobes: Fix 1 byte conditional jump target
Date: Mon, 6 Feb 2023 23:19:34 +0900 [thread overview]
Message-ID: <20230206231934.7ccbf7bf1f31b404783b10f9@kernel.org> (raw)
In-Reply-To: <5DFB6E19-210E-4EA8-8D71-66FF4A787942@gmail.com>
On Sun, 5 Feb 2023 09:49:56 +0200
Nadav Amit <nadav.amit@gmail.com> wrote:
>
>
> > On Feb 4, 2023, at 11:08 PM, Nadav Amit <nadav.amit@gmail.com> wrote:
> >
> > From: Nadav Amit <namit@vmware.com>
> >
> > Commit 3bc753c06dd0 ("kbuild: treat char as always unsigned") broke
> > kprobes. Setting a probe-point on 1 byte conditional jump can cause the
> > kernel to crash, as the branch target is not sign extended.
> >
> > Fix by using s8 instead of char and use immediate.value instead of
> > immediate.bytes for consistency.
>
> I guess I forgot to put a “Fixes” tag, since it is still not a real
> regression. (The bug was introduced in 6.2).
>
> Still, this fix should not fall between the cracks… Please let me know
> whether v2 is needed with a “fixes” tag.
No problem, I added Fixed tag with my Ack :)
Thank you!
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2023-02-06 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 21:08 [PATCH] x86/kprobes: Fix 1 byte conditional jump target Nadav Amit
2023-02-05 7:49 ` Nadav Amit
2023-02-06 14:19 ` Masami Hiramatsu [this message]
2023-02-06 14:18 ` Masami Hiramatsu
2023-02-06 18:42 ` Dave Hansen
2023-02-06 19:05 ` Nadav Amit
2023-02-06 22:38 ` Dave Hansen
2023-02-07 0:54 ` Masami Hiramatsu
2023-02-07 15:21 ` Masami Hiramatsu
2023-02-07 15:33 ` Dave Hansen
2023-02-08 6:34 ` Nadav Amit
2023-02-08 6:56 ` Dave Hansen
2023-02-08 6:58 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230206231934.7ccbf7bf1f31b404783b10f9@kernel.org \
--to=mhiramat@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox