* [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static
@ 2023-02-06 14:57 Tom Rix
2023-02-06 15:26 ` Chaitanya Kulkarni
2023-02-08 6:28 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Tom Rix @ 2023-02-06 14:57 UTC (permalink / raw)
To: hare, kbusch, axboe, hch, sagi; +Cc: linux-nvme, linux-kernel, Tom Rix
smatch reports
drivers/nvme/host/auth.c:48:25: warning: symbol 'nvme_auth_wq' was not declared. Should it be static?
nvme_auth_wq is only used in auth.c, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/nvme/host/auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
index b57630d1d3b8..bdb97496ba2d 100644
--- a/drivers/nvme/host/auth.c
+++ b/drivers/nvme/host/auth.c
@@ -45,7 +45,7 @@ struct nvme_dhchap_queue_context {
int sess_key_len;
};
-struct workqueue_struct *nvme_auth_wq;
+static struct workqueue_struct *nvme_auth_wq;
#define nvme_auth_flags_from_qid(qid) \
(qid == 0) ? 0 : BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED
--
2.26.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static
2023-02-06 14:57 [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static Tom Rix
@ 2023-02-06 15:26 ` Chaitanya Kulkarni
2023-02-08 6:28 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2023-02-06 15:26 UTC (permalink / raw)
To: Tom Rix, hare@suse.de, kbusch@kernel.org, axboe@fb.com,
hch@lst.de, sagi@grimberg.me
Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
On 2/6/23 06:57, Tom Rix wrote:
> smatch reports
> drivers/nvme/host/auth.c:48:25: warning: symbol 'nvme_auth_wq' was not declared. Should it be static?
>
> nvme_auth_wq is only used in auth.c, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/nvme/host/auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c
> index b57630d1d3b8..bdb97496ba2d 100644
> --- a/drivers/nvme/host/auth.c
> +++ b/drivers/nvme/host/auth.c
> @@ -45,7 +45,7 @@ struct nvme_dhchap_queue_context {
> int sess_key_len;
> };
>
> -struct workqueue_struct *nvme_auth_wq;
> +static struct workqueue_struct *nvme_auth_wq;
>
> #define nvme_auth_flags_from_qid(qid) \
> (qid == 0) ? 0 : BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_RESERVED
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static
2023-02-06 14:57 [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static Tom Rix
2023-02-06 15:26 ` Chaitanya Kulkarni
@ 2023-02-08 6:28 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-02-08 6:28 UTC (permalink / raw)
To: Tom Rix; +Cc: hare, kbusch, axboe, hch, sagi, linux-nvme, linux-kernel
Thanks,
applied to nvme-6.2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-08 6:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 14:57 [PATCH] nvme-auth: set nvme_auth_wq storage-class-specifier to static Tom Rix
2023-02-06 15:26 ` Chaitanya Kulkarni
2023-02-08 6:28 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox