From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 2/7] xhci: mem: Use dma_poll_zalloc() instead of explicit memset()
Date: Wed, 8 Feb 2023 17:11:24 +0200 [thread overview]
Message-ID: <20230208151129.28987-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20230208151129.28987-1-andriy.shevchenko@linux.intel.com>
Use dma_poll_zalloc() instead of explicit memset() call in
xhci_alloc_stream_ctx(). Note, that dma_alloc_coherent() is
always issues zeroed memory chunk.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/usb/host/xhci-mem.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index c385513ad00b..4ffa6495878d 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -575,10 +575,10 @@ static struct xhci_stream_ctx *xhci_alloc_stream_ctx(struct xhci_hcd *xhci,
return dma_alloc_coherent(dev, size,
dma, mem_flags);
else if (size <= SMALL_STREAM_ARRAY_SIZE)
- return dma_pool_alloc(xhci->small_streams_pool,
+ return dma_pool_zalloc(xhci->small_streams_pool,
mem_flags, dma);
else
- return dma_pool_alloc(xhci->medium_streams_pool,
+ return dma_pool_zalloc(xhci->medium_streams_pool,
mem_flags, dma);
}
@@ -643,8 +643,6 @@ struct xhci_stream_info *xhci_alloc_stream_info(struct xhci_hcd *xhci,
mem_flags);
if (!stream_info->stream_ctx_array)
goto cleanup_ring_array;
- memset(stream_info->stream_ctx_array, 0,
- sizeof(struct xhci_stream_ctx)*num_stream_ctxs);
/* Allocate everything needed to free the stream rings later */
stream_info->free_streams_command =
--
2.39.1
next prev parent reply other threads:[~2023-02-08 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:11 [PATCH v2 0/7] xhci: mem: Short cleanup series Andy Shevchenko
2023-02-08 15:11 ` [PATCH v2 1/7] xhci: mem: Carefully calculate size for memory allocations Andy Shevchenko
2023-02-08 15:11 ` Andy Shevchenko [this message]
2023-02-08 15:11 ` [PATCH v2 3/7] xhci: mem: Get rid of redundant 'else' Andy Shevchenko
2023-02-08 15:11 ` [PATCH v2 4/7] xhci: mem: Drop useless return:s Andy Shevchenko
2023-02-08 15:11 ` [PATCH v2 5/7] xhci: mem: Use while (i--) pattern to clean up Andy Shevchenko
2023-02-08 15:11 ` [PATCH v2 6/7] xhci: mem: Replace explicit castings with appropriate specifiers Andy Shevchenko
2023-02-08 15:11 ` [PATCH v2 7/7] xhci: mem: Join string literals back Andy Shevchenko
2023-02-10 14:31 ` [PATCH v2 0/7] xhci: mem: Short cleanup series Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208151129.28987-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox