Re: [PATCH 2/2] Documentation: cs35l41: Shared boost properties

Krzysztof Kozlowski
2023-02-07T10:43:03Z

On 07/02/2023 11:40, Lucas Tanure wrote:
> Describe the properties used for shared boost
> configuration.

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).

>
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
> .../devicetree/bindings/sound/cirrus,cs35l41.yaml | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
> index 18fb471aa891..6f5f01bec6f1 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
> @@ -85,11 +85,20 @@ properties:
> boost-cap-microfarad.
> External Boost must have GPIO1 as GPIO output. GPIO1 will be set high to
> enable boost voltage.
> + Shared boost allows two amplifiers to share a single boost circuit by
> + communicating on the MDSYNC bus. The passive amplifier does not control
> + the boost and receives data from the active amplifier. GPIO1 should be
> + configured for Sync when shared boost is used. Shared boost is not
> + compatible with External boost. Active amplifier requires
> + boost-peak-milliamp, boost-ind-nanohenry and boost-cap-microfarad.
> 0 = Internal Boost
> 1 = External Boost
> + 2 = Reserved

How binding can be reserved? For what and why? Drop. 2 is shared active,
3 is shared passive.

Best regards,
Krzysztof