Re: [PATCH 1/2] ALSA: cs35l41: Add shared boost feature

kernel test robot
2023-02-08T11:47:23Z

Hi Lucas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.2-rc7 next-20230208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Lucas-Tanure/ALSA-cs35l41-Add-shared-boost-feature/20230207-184238
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20230207104021.2842-2-lucas.tanure%40collabora.com
patch subject: [PATCH 1/2] ALSA: cs35l41: Add shared boost feature
config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20230208/202302081911.MDwfUTfx-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/c1726800667180cd46986c3578e635bafa8bf01a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Lucas-Tanure/ALSA-cs35l41-Add-shared-boost-feature/20230207-184238
git checkout c1726800667180cd46986c3578e635bafa8bf01a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash sound/soc/codecs/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/codecs/cs35l41-lib.c:1160:7: warning: variable 'ret' is used uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
case CS35L41_SHD_BOOST_PASS:
^~~~~~~~~~~~~~~~~~~~~~
sound/soc/codecs/cs35l41-lib.c:1169:9: note: uninitialized use occurs here
return ret;
^~~
sound/soc/codecs/cs35l41-lib.c:1136:9: note: initialize the variable 'ret' to silence this warning
int ret;
^
= 0
1 warning generated.

vim +/ret +1160 sound/soc/codecs/cs35l41-lib.c

1132
1133 int cs35l41_init_boost(struct device *dev, struct regmap *regmap,
1134 struct cs35l41_hw_cfg *hw_cfg)
1135 {
1136 int ret;
1137
1138 switch (hw_cfg->bst_type) {
1139 case CS35L41_SHD_BOOST_ACTV:
1140 regmap_multi_reg_write(regmap, cs35l41_actv_seq, ARRAY_SIZE(cs35l41_actv_seq));
1141 fallthrough;
1142 case CS35L41_INT_BOOST:
1143 ret = cs35l41_boost_config(dev, regmap, hw_cfg->bst_ind,
1144 hw_cfg->bst_cap, hw_cfg->bst_ipk);
1145 if (ret)
1146 dev_err(dev, "Error in Boost DT config: %d\n", ret);
1147 break;
1148 case CS35L41_EXT_BOOST:
1149 case CS35L41_EXT_BOOST_NO_VSPK_SWITCH:
1150 /* Only CLSA0100 doesn't use GPIO as VSPK switch, but even on that laptop we can
1151 * toggle GPIO1 as is not connected to anything.
1152 * There will be no other device without VSPK switch.
1153 */
1154 regmap_write(regmap, CS35L41_GPIO1_CTRL1, 0x00000001);
1155 regmap_multi_reg_write(regmap, cs35l41_reset_to_safe,
1156 ARRAY_SIZE(cs35l41_reset_to_safe));
1157 ret = regmap_update_bits(regmap, CS35L41_PWR_CTRL2, CS35L41_BST_EN_MASK,
1158 CS35L41_BST_DIS_FET_OFF << CS35L41_BST_EN_SHIFT);
1159 break;
> 1160 case CS35L41_SHD_BOOST_PASS:
1161 regmap_multi_reg_write(regmap, cs35l41_pass_seq, ARRAY_SIZE(cs35l41_pass_seq));
1162 break;
1163 default:
1164 dev_err(dev, "Boost type %d not supported\n", hw_cfg->bst_type);
1165 ret = -EINVAL;
1166 break;
1167 }
1168
1169 return ret;
1170 }
1171 EXPORT_SYMBOL_GPL(cs35l41_init_boost);
1172

--
0-DAY CI Kernel Test Service