public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: lists@nerdbynature.de, mikelley@microsoft.com,
	torvalds@linux-foundation.org, Juergen Gross <jgross@suse.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH v2 8/8] x86/mtrr: drop sanity check in mtrr_type_lookup_fixed()
Date: Thu,  9 Feb 2023 08:22:20 +0100	[thread overview]
Message-ID: <20230209072220.6836-9-jgross@suse.com> (raw)
In-Reply-To: <20230209072220.6836-1-jgross@suse.com>

mtrr_type_lookup_fixed() contains a sanity check for the case it is
being called with a start address above 1 MB. As it is static and it
is called only iff the start address is below 1MB, this sanity check
can be dropped.

This will remove the last case where mtrr_type_lookup() can return
MTRR_TYPE_INVALID, so adjust the comment in include/uapi/asm/mtrr.h.

Note that removing the MTRR_TYPE_INVALID #define from that header
could break user code, so it has to stay.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/include/uapi/asm/mtrr.h   | 6 +++---
 arch/x86/kernel/cpu/mtrr/generic.c | 6 +-----
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/x86/include/uapi/asm/mtrr.h b/arch/x86/include/uapi/asm/mtrr.h
index 376563f2bac1..4aa05c2ffa78 100644
--- a/arch/x86/include/uapi/asm/mtrr.h
+++ b/arch/x86/include/uapi/asm/mtrr.h
@@ -115,9 +115,9 @@ struct mtrr_state_type {
 #define MTRR_NUM_TYPES       7
 
 /*
- * Invalid MTRR memory type.  mtrr_type_lookup() returns this value when
- * MTRRs are disabled.  Note, this value is allocated from the reserved
- * values (0x7-0xff) of the MTRR memory types.
+ * Invalid MTRR memory type.  No longer used outside of MTRR code.
+ * Note, this value is allocated from the reserved values (0x7-0xff) of
+ * the MTRR memory types.
  */
 #define MTRR_TYPE_INVALID    0xff
 
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
index afb59ff2cc00..575b050a55bf 100644
--- a/arch/x86/kernel/cpu/mtrr/generic.c
+++ b/arch/x86/kernel/cpu/mtrr/generic.c
@@ -114,16 +114,12 @@ static int check_type_overlap(u8 *prev, u8 *curr)
  *  0xC0000 - 0xFFFFF : This range is divided into sixty-four 4KB sub-ranges
  *
  * Return Values:
- * MTRR_TYPE_(type)  - Matched memory type
- * MTRR_TYPE_INVALID - Unmatched
+ * MTRR_TYPE_(type)  - Memory type
  */
 static u8 mtrr_type_lookup_fixed(u64 start, u64 end)
 {
 	int idx;
 
-	if (start >= 0x100000)
-		return MTRR_TYPE_INVALID;
-
 	/* 0x0 - 0x7FFFF */
 	if (start < 0x80000) {
 		idx = 0;
-- 
2.35.3


  parent reply	other threads:[~2023-02-09  7:23 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09  7:22 [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Juergen Gross
2023-02-09  7:22 ` [PATCH v2 1/8] x86/mtrr: split off physical address size calculation Juergen Gross
2023-02-11 10:08   ` Borislav Petkov
2023-02-13  6:19     ` Juergen Gross
2023-02-09  7:22 ` [PATCH v2 2/8] x86/mtrr: support setting MTRR state for software defined MTRRs Juergen Gross
2023-02-13  1:07   ` Michael Kelley (LINUX)
2023-02-13  6:27     ` Juergen Gross
2023-02-13  6:43       ` Michael Kelley (LINUX)
2023-02-13 11:39   ` Borislav Petkov
2023-02-13 14:07     ` Juergen Gross
2023-02-13 15:03       ` Borislav Petkov
2023-02-13 15:11         ` Borislav Petkov
2023-02-13 15:18           ` Juergen Gross
2023-02-13 15:40             ` Borislav Petkov
2023-02-13 15:44               ` Juergen Gross
2023-02-13 18:53                 ` Borislav Petkov
2023-02-14  7:04                   ` Juergen Gross
2023-02-14  8:58                     ` Borislav Petkov
2023-02-14  9:02                       ` Juergen Gross
2023-02-14  9:10                         ` Borislav Petkov
2023-02-14  9:17                           ` Juergen Gross
2023-02-14  9:32                             ` Borislav Petkov
2023-02-13 15:27           ` Dave Hansen
2023-02-13 15:38             ` Juergen Gross
2023-02-13 15:36         ` Juergen Gross
2023-02-13 18:43           ` Borislav Petkov
2023-02-14  7:01             ` Juergen Gross
2023-02-14  0:45       ` Kirill A. Shutemov
2023-02-16  9:32     ` Juergen Gross
2023-02-16 11:02       ` Jeremi Piotrowski
2023-02-16 11:25       ` Borislav Petkov
2023-02-16 12:19         ` Juergen Gross
2023-02-16 12:29           ` Borislav Petkov
2023-02-16 16:04             ` Michael Kelley (LINUX)
2023-02-16 11:07     ` Jeremi Piotrowski
2023-02-16 11:27       ` Borislav Petkov
2023-02-09  7:22 ` [PATCH v2 3/8] x86/hyperv: set MTRR state when running as SEV-SNP Hyper-V guest Juergen Gross
2023-02-13  1:07   ` Michael Kelley (LINUX)
2023-02-13  6:28     ` Juergen Gross
2023-02-09  7:22 ` [PATCH v2 4/8] x86/xen: set MTRR state when running as Xen PV initial domain Juergen Gross
2023-02-09  7:22 ` [PATCH v2 5/8] x86/mtrr: revert commit 90b926e68f50 Juergen Gross
2023-02-10 18:59   ` Linux regression tracking (Thorsten Leemhuis)
2023-02-13  6:07     ` Juergen Gross
2023-02-13 11:46       ` Christian Kujau
2023-02-13 16:23         ` Juergen Gross
2023-02-13 17:01           ` Michael Kelley (LINUX)
2023-02-13 17:24             ` Juergen Gross
2023-02-13 22:54           ` Christian Kujau
2023-02-14  7:13             ` Juergen Gross
2023-02-09  7:22 ` [PATCH v2 6/8] x86/mtrr: don't let mtrr_type_lookup() return MTRR_TYPE_INVALID Juergen Gross
2023-02-09  7:22 ` [PATCH v2 7/8] x86/mm: only check uniform after calling mtrr_type_lookup() Juergen Gross
2023-02-11  0:06   ` Edgecombe, Rick P
2023-02-13  6:08     ` Juergen Gross
2023-02-13  1:08   ` Michael Kelley (LINUX)
2023-02-13  6:35     ` Juergen Gross
2023-02-15 13:40     ` Juergen Gross
2023-02-15 19:38       ` Michael Kelley (LINUX)
2023-02-16  5:22         ` Juergen Gross
2023-02-09  7:22 ` Juergen Gross [this message]
2023-02-11  0:06 ` [PATCH v2 0/8] x86/mtrr: fix handling with PAT but without MTRR Edgecombe, Rick P
2023-02-13  6:12   ` Juergen Gross
2023-02-13 18:21     ` Edgecombe, Rick P
2023-02-15  8:25       ` Juergen Gross
2023-02-15 23:22         ` Linus Torvalds
2023-02-16  5:35           ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209072220.6836-9-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists@nerdbynature.de \
    --cc=mikelley@microsoft.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox