From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC665C05027 for ; Thu, 9 Feb 2023 11:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231590AbjBIL3Z (ORCPT ); Thu, 9 Feb 2023 06:29:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230300AbjBIL2V (ORCPT ); Thu, 9 Feb 2023 06:28:21 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E60CC6BA82; Thu, 9 Feb 2023 03:21:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C743A619E8; Thu, 9 Feb 2023 11:20:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44891C4339C; Thu, 9 Feb 2023 11:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675941627; bh=VDUNcmFfGTzo56vOCStREerT2zCA20lHUHxST9xIdl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WceDjkFiP1v+gXqWwpwRXv4H4eRzdulFy2jAnVOsRrb10ILzhCHRFVRX5S1ZSK2hx vu7DEOFOpkJidUm6nvbkApC8IVt/9Jfc0VzHDZWkTl/pyH054gJxZFlN2MlAdm1Sdp 96+C+mCIAiwXH+7QWyzmGwt5amViGTYCD8CMXQp2shwcNSBQfA6isYTuUippRvpfBY AVmMZLKYTtILEQUlToNWeNYa4ckZhndzIlmPM9rGzph4NyjdCZW5m8iEsSlESuUu1Q Urz1uVwx5pNPgYVVPggtkdCFPhpettEf8J0ZWRwohorzMlr8t5ZTGXabSlbac0nAk2 nY4kbxE/em9PA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Amit Engel , James Smart , Christoph Hellwig , Sasha Levin , james.smart@broadcom.com, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 6/6] nvme-fc: fix a missing queue put in nvmet_fc_ls_create_association Date: Thu, 9 Feb 2023 06:19:59 -0500 Message-Id: <20230209111959.1893269-6-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230209111959.1893269-1-sashal@kernel.org> References: <20230209111959.1893269-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Amit Engel [ Upstream commit 0cab4404874f2de52617de8400c844891c6ea1ce ] As part of nvmet_fc_ls_create_association there is a case where nvmet_fc_alloc_target_queue fails right after a new association with an admin queue is created. In this case, no one releases the get taken in nvmet_fc_alloc_target_assoc. This fix is adding the missing put. Signed-off-by: Amit Engel Reviewed-by: James Smart Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/target/fc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index 77e4d184bc995..68d128b895abd 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -1325,8 +1325,10 @@ nvmet_fc_ls_create_association(struct nvmet_fc_tgtport *tgtport, else { queue = nvmet_fc_alloc_target_queue(iod->assoc, 0, be16_to_cpu(rqst->assoc_cmd.sqsize)); - if (!queue) + if (!queue) { ret = VERR_QUEUE_ALLOC_FAIL; + nvmet_fc_tgt_a_put(iod->assoc); + } } } -- 2.39.0