From: Guenter Roeck <linux@roeck-us.net>
To: ye.xingchen@zte.com.cn
Cc: nick.hawkins@hpe.com, verdun@hpe.com, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource()
Date: Thu, 9 Feb 2023 09:37:59 -0800 [thread overview]
Message-ID: <20230209173759.GA652733@roeck-us.net> (raw)
In-Reply-To: <202302081546067270324@zte.com.cn>
On Wed, Feb 08, 2023 at 03:46:06PM +0800, ye.xingchen@zte.com.cn wrote:
> From: Ye Xingchen <ye.xingchen@zte.com.cn>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@zte.com.cn>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/gxp-fan-ctrl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/gxp-fan-ctrl.c b/drivers/hwmon/gxp-fan-ctrl.c
> index 0e9225a8b805..0014b8b0fd41 100644
> --- a/drivers/hwmon/gxp-fan-ctrl.c
> +++ b/drivers/hwmon/gxp-fan-ctrl.c
> @@ -199,7 +199,6 @@ static const struct hwmon_chip_info gxp_fan_ctrl_chip_info = {
> static int gxp_fan_ctrl_probe(struct platform_device *pdev)
> {
> struct gxp_fan_ctrl_drvdata *drvdata;
> - struct resource *res;
> struct device *dev = &pdev->dev;
> struct device *hwmon_dev;
>
> @@ -208,8 +207,7 @@ static int gxp_fan_ctrl_probe(struct platform_device *pdev)
> if (!drvdata)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - drvdata->base = devm_ioremap_resource(&pdev->dev, res);
> + drvdata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(drvdata->base))
> return dev_err_probe(dev, PTR_ERR(drvdata->base),
> "failed to map base\n");
prev parent reply other threads:[~2023-02-09 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 7:46 [PATCH] hwmon: gxp-fan-ctrl: use devm_platform_get_and_ioremap_resource() ye.xingchen
2023-02-09 17:37 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209173759.GA652733@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick.hawkins@hpe.com \
--cc=verdun@hpe.com \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox