From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Deepak R Varma <drv@mailo.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Saurabh Singh Sengar <ssengar@microsoft.com>,
Praveen Kumar <kumarpraveen@linux.microsoft.com>
Subject: Re: [PATCH] wifi: rt2x00: remove impossible test condition
Date: Thu, 9 Feb 2023 19:10:46 +0100 [thread overview]
Message-ID: <20230209181046.GA1446693@wp.pl> (raw)
In-Reply-To: <Y+S3bu19GWZeR9pm@ubun2204.myguest.virtualbox.org>
On Thu, Feb 09, 2023 at 02:35:50PM +0530, Deepak R Varma wrote:
> Variable vga_gain is a u8 and will never attain a value less than 0.
> Hence testing it for less 0 is impossible.
> Issue identified using unsigned_lesser_than_zero.cocci Coccinelle
> semantic patch. The issue was also reported by Kernel test Robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
parent reply other threads:[~2023-02-09 18:11 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <Y+S3bu19GWZeR9pm@ubun2204.myguest.virtualbox.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209181046.GA1446693@wp.pl \
--to=stf_xl@wp.pl \
--cc=davem@davemloft.net \
--cc=drv@mailo.com \
--cc=edumazet@google.com \
--cc=helmut.schaa@googlemail.com \
--cc=kuba@kernel.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ssengar@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox