Re: [PATCH v6 21/26] powerpc/pseries: Clarify warning when PLPKS password already set

Stefan Berger
2023-02-10T20:48:14Z

On 2/10/23 03:03, Andrew Donnellan wrote:
> When the H_PKS_GEN_PASSWORD hcall returns H_IN_USE, operations that require
> authentication (i.e. anything other than reading a world-readable variable)
> will not work.
>
> The current error message doesn't explain this clearly enough. Reword it
> to emphasise that authenticated operations will fail.

typo: -> emphasize

>
> Signed-off-by: Andrew Donnellan <ajd@linux.ibm.com>
>
> ---
>
> v6: New patch
> ---
> arch/powerpc/platforms/pseries/plpks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
> index 926b6a927326..01ae919b4497 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -146,7 +146,7 @@ static int plpks_gen_password(void)
> memcpy(ospassword, password, ospasswordlength);
> } else {
> if (rc == H_IN_USE) {
> - pr_warn("Password is already set for POWER LPAR Platform KeyStore\n");
> + pr_warn("Password already set - authenticated operations will fail\n");
> rc = 0;
> } else {
> goto out;