Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot

Michael Ellerman
2023-02-13T05:27:18Z

Andrew Donnellan <ajd@linux.ibm.com> writes:
> On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote:
>> > > +err:
>> > > +    kfree(var.data);
>> >
>> > remove the kfree()
>>
>> Actually don't remove it but it should probably be
>>
>> if (var.data != &version)
>>      kfree(var.data);
>>
>
> Argh, thanks for catching this.
>
> I don't think the condition is needed - we can assume the var.data is
> unmodified.
>
> mpe, are you able to fix this up in merge?

Yeah, can you reply here with the delta you want applied.

cheers