Re: [PATCH 1/2] tty: new helper function tty_get_mget

kernel test robot
2023-02-13T21:50:45Z

Hi Florian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on tty/tty-next tty/tty-linus pavel-leds/for-next staging/staging-testing staging/staging-next staging/staging-linus linus/master v6.2-rc8 next-20230213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230213-223413
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
patch link: https://lore.kernel.org/r/20230213140638.620206-2-fe%40dev.tdt.de
patch subject: [PATCH 1/2] tty: new helper function tty_get_mget
config: x86_64-randconfig-a005-20230213 (https://download.01.org/0day-ci/archive/20230214/202302140536.fks6kujh-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/096ca9c9428ec2a8ebab4af0798461e66585cdde
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Florian-Eckert/tty-new-helper-function-tty_get_mget/20230213-223413
git checkout 096ca9c9428ec2a8ebab4af0798461e66585cdde
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202302140536.fks6kujh-lkp@intel.com/

All errors (new ones prefixed by >>):

In file included from drivers/leds/trigger/ledtrig-tty.c:7:
include/linux/tty.h:423:3: error: expected ')'
struct serial_icounter_struct *icount);
^
include/linux/tty.h:422:19: note: to match this '('
int tty_get_icount(struct tty_struct *tty
^
>> drivers/leds/trigger/ledtrig-tty.c:116:42: error: too many arguments to function call, expected single argument 'tty', have 2 arguments
ret = tty_get_icount(trigger_data->tty, &icount);
~~~~~~~~~~~~~~ ^~~~~~~
include/linux/tty.h:422:5: note: 'tty_get_icount' declared here
int tty_get_icount(struct tty_struct *tty
^
2 errors generated.

vim +/tty +116 drivers/leds/trigger/ledtrig-tty.c

fd4a641ac88fbb Uwe Kleine-König 2021-01-13 78
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 79 static void ledtrig_tty_work(struct work_struct *work)
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 80 {
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 81 struct ledtrig_tty_data *trigger_data =
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 82 container_of(work, struct ledtrig_tty_data, dwork.work);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 83 struct serial_icounter_struct icount;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 84 int ret;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 85
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 86 mutex_lock(&trigger_data->mutex);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 87
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 88 if (!trigger_data->ttyname) {
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 89 /* exit without rescheduling */
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 90 mutex_unlock(&trigger_data->mutex);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 91 return;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 92 }
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 93
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 94 /* try to get the tty corresponding to $ttyname */
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 95 if (!trigger_data->tty) {
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 96 dev_t devno;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 97 struct tty_struct *tty;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 98 int ret;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 99
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 100 ret = tty_dev_name_to_number(trigger_data->ttyname, &devno);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 101 if (ret < 0)
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 102 /*
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 103 * A device with this name might appear later, so keep
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 104 * retrying.
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 105 */
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 106 goto out;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 107
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 108 tty = tty_kopen_shared(devno);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 109 if (IS_ERR(tty) || !tty)
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 110 /* What to do? retry or abort */
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 111 goto out;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 112
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 113 trigger_data->tty = tty;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 114 }
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 115
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 @116 ret = tty_get_icount(trigger_data->tty, &icount);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 117 if (ret) {
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 118 dev_info(trigger_data->tty->dev, "Failed to get icount, stopped polling\n");
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 119 mutex_unlock(&trigger_data->mutex);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 120 return;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 121 }
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 122
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 123 if (icount.rx != trigger_data->rx ||
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 124 icount.tx != trigger_data->tx) {
ba8a86e4dadb33 Uwe Kleine-König 2021-02-19 125 led_set_brightness_sync(trigger_data->led_cdev, LED_ON);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 126
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 127 trigger_data->rx = icount.rx;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 128 trigger_data->tx = icount.tx;
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 129 } else {
ba8a86e4dadb33 Uwe Kleine-König 2021-02-19 130 led_set_brightness_sync(trigger_data->led_cdev, LED_OFF);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 131 }
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 132
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 133 out:
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 134 mutex_unlock(&trigger_data->mutex);
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 135 schedule_delayed_work(&trigger_data->dwork, msecs_to_jiffies(100));
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 136 }
fd4a641ac88fbb Uwe Kleine-König 2021-01-13 137

--
0-DAY CI Kernel Test Service