From: Frieder Schrempf <frieder@fris.de>
To: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Cc: "Marek Vasut" <marex@denx.de>,
"Frieder Schrempf" <frieder.schrempf@kontron.de>,
"Per-Daniel Olsson" <perdo@axis.com>,
"Rickard x Andersson" <rickaran@axis.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: [PATCH 3/6] Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5"
Date: Mon, 13 Feb 2023 16:58:21 +0100 [thread overview]
Message-ID: <20230213155833.1644366-4-frieder@fris.de> (raw)
In-Reply-To: <20230213155833.1644366-1-frieder@fris.de>
From: Frieder Schrempf <frieder.schrempf@kontron.de>
This reverts commit 8c67a11bae889f51fe5054364c3c789dfae3ad73.
It turns out that all boards using the PCA9450 actually have the
SD_VSEL input conencted to the VSELECT signal of the SoCs SD/MMC
interface. Therefore we don't need manual control for this signal
via GPIO and threre aren't any users.
Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
drivers/regulator/pca9450-regulator.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index a815666566b5..804a22c0e376 100644
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -5,7 +5,6 @@
*/
#include <linux/err.h>
-#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
#include <linux/kernel.h>
@@ -33,7 +32,6 @@ struct pca9450_regulator_desc {
struct pca9450 {
struct device *dev;
struct regmap *regmap;
- struct gpio_desc *sd_vsel_gpio;
enum pca9450_chip_type type;
unsigned int rcnt;
int irq;
@@ -834,18 +832,6 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
}
}
- /*
- * The driver uses the LDO5CTRL_H register to control the LDO5 regulator.
- * This is only valid if the SD_VSEL input of the PMIC is high. Let's
- * check if the pin is available as GPIO and set it to high.
- */
- pca9450->sd_vsel_gpio = gpiod_get_optional(pca9450->dev, "sd-vsel", GPIOD_OUT_HIGH);
-
- if (IS_ERR(pca9450->sd_vsel_gpio)) {
- dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");
- return PTR_ERR(pca9450->sd_vsel_gpio);
- }
-
dev_info(&i2c->dev, "%s probed.\n",
type == PCA9450_TYPE_PCA9450A ? "pca9450a" : "pca9450bc");
--
2.39.1
next prev parent reply other threads:[~2023-02-13 16:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 15:58 [PATCH 0/6] Use correct LDO5 control registers for PCA9450 Frieder Schrempf
2023-02-13 15:58 ` [PATCH 1/6] dt-bindings: regulator: pca9450: Document new usage of sd-vsel-gpios Frieder Schrempf
2023-02-15 20:02 ` Rob Herring
2023-02-16 1:27 ` Marek Vasut
2023-02-16 2:30 ` Rob Herring
2023-02-16 10:15 ` Frieder Schrempf
2023-02-13 15:58 ` [PATCH 2/6] regulator: pca9450: Fix enable register for LDO5 Frieder Schrempf
2023-02-13 16:12 ` Marek Vasut
2023-02-13 15:58 ` Frieder Schrempf [this message]
2023-02-13 16:16 ` [PATCH 3/6] Revert "regulator: pca9450: Add SD_VSEL GPIO for LDO5" Marek Vasut
2023-02-13 16:23 ` Frieder Schrempf
2023-02-13 18:10 ` Marek Vasut
2023-02-13 15:58 ` [PATCH 4/6] regulator: Add operation to let drivers select vsel register Frieder Schrempf
2023-02-14 1:40 ` kernel test robot
2023-02-14 9:19 ` kernel test robot
2023-02-14 21:06 ` Mark Brown
2023-02-16 9:05 ` Frieder Schrempf
2023-02-16 14:31 ` Mark Brown
2023-02-13 15:58 ` [PATCH 5/6] regulator: pca9450: Fix control register for LDO5 Frieder Schrempf
2023-02-13 15:58 ` [PATCH 6/6] arm64: dts: imx8mm-kontron: Add support for reading SD_VSEL signal Frieder Schrempf
2023-02-13 16:08 ` Marek Vasut
2023-02-13 16:15 ` Frieder Schrempf
2023-02-13 16:15 ` Marco Felsch
2023-02-13 16:18 ` Frieder Schrempf
2023-02-13 21:02 ` Fabio Estevam
2023-02-13 18:12 ` Marek Vasut
2023-02-13 19:56 ` Marco Felsch
2023-02-13 20:59 ` Marek Vasut
2023-02-14 8:10 ` Marco Felsch
2023-02-14 8:26 ` Frieder Schrempf
2023-02-14 11:46 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230213155833.1644366-4-frieder@fris.de \
--to=frieder@fris.de \
--cc=broonie@kernel.org \
--cc=frieder.schrempf@kontron.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=perdo@axis.com \
--cc=rickaran@axis.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox