Re: [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter

Sergey Shtylyov
2023-02-18T16:16:16Z

On 2/15/23 10:45 PM, Ondrej Zary wrote:

> Only bpck driver uses devtype but it never gets set in pata_parport.
> Remove it.
> As most bpck devices are CD-ROMs, always run the code that depends
> on devtype == PI_PCD.
>
> Signed-off-by: Ondrej Zary <linux@zary.sk>

Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>

[...]

> diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
> index b9174cf8863c..96386a10c22f 100644
> --- a/drivers/ata/pata_parport/bpck.c
> +++ b/drivers/ata/pata_parport/bpck.c
> @@ -241,14 +241,14 @@ static void bpck_connect ( PIA *pi )
>
> WR(5,8);
>
> - if (pi->devtype == PI_PCD) {
> +/* if (pi->devtype == PI_PCD) { possibly wrong, purpose unknown */
> WR(0x46,0x10); /* fiddle with ESS logic ??? */
> WR(0x4c,0x38);
> WR(0x4d,0x88);
> WR(0x46,0xa0);
> WR(0x41,0);
> WR(0x4e,8);
> - }
> +/* }*/

You could have used // here, scripts/checkpatch.pl has nothing against it now...

[...]

MBR, Sergey