public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource()
@ 2023-02-16  6:34 Yang Li
  2023-02-21  6:45 ` Shuai Xue
  2023-03-27 15:01 ` Will Deacon
  0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2023-02-16  6:34 UTC (permalink / raw)
  To: xueshuai; +Cc: will, mark.rutland, linux-arm-kernel, linux-kernel, Yang Li

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/perf/alibaba_uncore_drw_pmu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
index a7689fecb49d..5c5be9fc1b15 100644
--- a/drivers/perf/alibaba_uncore_drw_pmu.c
+++ b/drivers/perf/alibaba_uncore_drw_pmu.c
@@ -656,8 +656,7 @@ static int ali_drw_pmu_probe(struct platform_device *pdev)
 	drw_pmu->dev = &pdev->dev;
 	platform_set_drvdata(pdev, drw_pmu);
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	drw_pmu->cfg_base = devm_ioremap_resource(&pdev->dev, res);
+	drw_pmu->cfg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
 	if (IS_ERR(drw_pmu->cfg_base))
 		return PTR_ERR(drw_pmu->cfg_base);
 
-- 
2.20.1.7.g153144c


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource()
  2023-02-16  6:34 [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource() Yang Li
@ 2023-02-21  6:45 ` Shuai Xue
  2023-03-27 15:01 ` Will Deacon
  1 sibling, 0 replies; 3+ messages in thread
From: Shuai Xue @ 2023-02-21  6:45 UTC (permalink / raw)
  To: Yang Li; +Cc: will, mark.rutland, linux-arm-kernel, linux-kernel



On 2023/2/16 PM2:34, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  drivers/perf/alibaba_uncore_drw_pmu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c
> index a7689fecb49d..5c5be9fc1b15 100644
> --- a/drivers/perf/alibaba_uncore_drw_pmu.c
> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c
> @@ -656,8 +656,7 @@ static int ali_drw_pmu_probe(struct platform_device *pdev)
>  	drw_pmu->dev = &pdev->dev;
>  	platform_set_drvdata(pdev, drw_pmu);
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	drw_pmu->cfg_base = devm_ioremap_resource(&pdev->dev, res);
> +	drw_pmu->cfg_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(drw_pmu->cfg_base))
>  		return PTR_ERR(drw_pmu->cfg_base);
>  

LGTM. Thank you.

Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>

Best Regards,
Shuai

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource()
  2023-02-16  6:34 [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource() Yang Li
  2023-02-21  6:45 ` Shuai Xue
@ 2023-03-27 15:01 ` Will Deacon
  1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2023-03-27 15:01 UTC (permalink / raw)
  To: Yang Li, xueshuai
  Cc: catalin.marinas, kernel-team, Will Deacon, linux-arm-kernel,
	mark.rutland, linux-kernel

On Thu, 16 Feb 2023 14:34:03 +0800, Yang Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> 

Applied to will (for-next/perf), thanks!

[1/1] drivers/perf: Use devm_platform_get_and_ioremap_resource()
      https://git.kernel.org/will/c/bc12f344d5de

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-27 15:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-16  6:34 [PATCH -next] drivers/perf: Use devm_platform_get_and_ioremap_resource() Yang Li
2023-02-21  6:45 ` Shuai Xue
2023-03-27 15:01 ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox