From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
Jason Gunthorpe <jgg@nvidia.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
"David Woodhouse" <dwmw2@infradead.org>,
Raj Ashok <ashok.raj@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>, X86 Kernel <x86@kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v3 4/5] iommu/ioasid: Rename INVALID_IOASID
Date: Fri, 17 Feb 2023 08:32:40 -0800 [thread overview]
Message-ID: <20230217083240.147d2c76@jacob-builder> (raw)
In-Reply-To: <25fbbc7f-f137-c2c4-ddf8-d143fce1dcc5@intel.com>
Hi Fenghua,
On Thu, 16 Feb 2023 17:23:15 -0800, Fenghua Yu <fenghua.yu@intel.com> wrote:
> > --- a/drivers/dma/idxd/irq.c
> > +++ b/drivers/dma/idxd/irq.c
> > @@ -80,7 +80,7 @@ static void idxd_int_handle_revoke_drain(struct
> > idxd_irq_entry *ie) desc.opcode = DSA_OPCODE_DRAIN;
> > desc.priv = 1;
> >
> > - if (ie->pasid != INVALID_IOASID)
> > + if (ie->pasid != IOMMU_PASID_INVALID)
>
> It's better to change to:
> + if (pasid_valid(ie->paid))
>
> If pasid_vaild() is called, any invalid PASID value change in the future
> will be hidden in pasid_valid() and won't impact this code any more.
>
> And checking pasid_valid() is more readable and meaninful than direct
> checking the invalid PASID value.
Sounds good, here I'm just renaming. I will submit another patch to
convert.
Thanks,
Jacob
next prev parent reply other threads:[~2023-02-17 16:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 23:59 [PATCH v3 0/5] Remove VT-d virtual command interface and IOASID Jacob Pan
2023-02-16 23:59 ` [PATCH v3 1/5] iommu/vt-d: Remove virtual command interface Jacob Pan
2023-02-16 23:59 ` [PATCH v3 2/5] iommu/sva: Move PASID helpers to sva code Jacob Pan
2023-02-16 23:58 ` Jason Gunthorpe
2023-02-16 23:59 ` [PATCH v3 3/5] iommu/sva: Stop using ioasid_set for SVA Jacob Pan
2023-02-22 2:22 ` Tian, Kevin
2023-02-22 6:19 ` Jacob Pan
2023-02-16 23:59 ` [PATCH v3 4/5] iommu/ioasid: Rename INVALID_IOASID Jacob Pan
2023-02-16 23:59 ` Jason Gunthorpe
2023-02-17 1:23 ` Fenghua Yu
2023-02-17 16:32 ` Jacob Pan [this message]
2023-02-17 16:13 ` Dave Jiang
2023-02-16 23:59 ` [PATCH v3 5/5] iommu: Remove ioasid infrastructure Jacob Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217083240.147d2c76@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox