From: Vladimir Oltean <olteanv@gmail.com>
To: Rakesh Sankaranarayanan <rakesh.sankaranarayanan@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v2 net-next 2/5] net: dsa: microchip: add eth ctrl grouping for ethtool statistics
Date: Fri, 17 Feb 2023 19:08:22 +0200 [thread overview]
Message-ID: <20230217170822.w65c72hsbbnoqcab@skbuf> (raw)
In-Reply-To: <20230217110211.433505-3-rakesh.sankaranarayanan@microchip.com>
On Fri, Feb 17, 2023 at 04:32:08PM +0530, Rakesh Sankaranarayanan wrote:
> +void ksz8_get_eth_ctrl_stats(struct ksz_device *dev, int port,
> + struct ethtool_eth_ctrl_stats *ctrl_stats)
> +{
> + struct ksz_port_mib *mib;
> + u64 *cnt;
> +
> + mib = &dev->ports[port].mib;
> +
> + mutex_lock(&mib->cnt_mutex);
> +
> + cnt = &mib->counters[KSZ8_TX_PAUSE];
> + dev->dev_ops->r_mib_pkt(dev, port, KSZ8_TX_PAUSE, NULL, cnt);
> + ctrl_stats->MACControlFramesTransmitted = *cnt;
> +
> + cnt = &mib->counters[KSZ8_RX_PAUSE];
> + dev->dev_ops->r_mib_pkt(dev, port, KSZ8_RX_PAUSE, NULL, cnt);
> + ctrl_stats->MACControlFramesReceived = *cnt;
> +
> + mutex_unlock(&mib->cnt_mutex);
> +}
These should be reported as standard pause stats as well (ethtool -I --show-pause swpN).
next prev parent reply other threads:[~2023-02-17 17:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 11:02 [PATCH v2 net-next 0/5] add ethtool categorized statistics Rakesh Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 1/5] net: dsa: microchip: add rmon grouping for ethtool statistics Rakesh Sankaranarayanan
2023-02-17 14:59 ` Alexander Lobakin
2023-02-21 4:37 ` Rakesh.Sankaranarayanan
2023-02-17 16:53 ` Vladimir Oltean
2023-02-17 17:40 ` Andrew Lunn
2023-02-21 4:40 ` Rakesh.Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 2/5] net: dsa: microchip: add eth ctrl " Rakesh Sankaranarayanan
2023-02-17 17:08 ` Vladimir Oltean [this message]
2023-02-21 7:14 ` Rakesh.Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 3/5] net: dsa: microchip: add eth mac " Rakesh Sankaranarayanan
2023-02-17 15:01 ` Alexander Lobakin
2023-02-17 16:42 ` Vladimir Oltean
2023-02-24 16:07 ` Alexander Lobakin
2023-02-24 21:53 ` Vladimir Oltean
2023-02-27 14:31 ` Alexander Lobakin
2023-02-27 14:52 ` Andrew Lunn
2023-02-28 10:53 ` Alexander Lobakin
2023-02-17 11:02 ` [PATCH v2 net-next 4/5] net: dsa: microchip: add eth phy " Rakesh Sankaranarayanan
2023-02-17 11:02 ` [PATCH v2 net-next 5/5] net: dsa: microchip: remove num_alus_variable Rakesh Sankaranarayanan
2023-02-17 17:16 ` Vladimir Oltean
2023-02-21 7:25 ` Rakesh.Sankaranarayanan
2023-02-17 14:54 ` [PATCH v2 net-next 0/5] add ethtool categorized statistics Alexander Lobakin
2023-02-17 16:48 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217170822.w65c72hsbbnoqcab@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rakesh.sankaranarayanan@microchip.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox