Re: [PATCH v4 06/11] net/9p: fix bug in client create for .L

asmadeus
2023-02-18T08:02:17Z

Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:18AM +0000:
> We are supposed to set fid->mode to reflect the flags
> that were used to open the file. We were actually setting
> it to the creation mode which is the default perms of the
> file not the flags the file was opened with.
>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>

I was about to say fcreate has the same problem, but TCREATE's mode
actually is the open mode (0 (called OREAD), 1 (OWRITE), 2 (ORDWR), and
3 (OEXEC)) and dotl's create is called perm :|

I guess that's where the mistake came from... Good catch!
(and there's also p9_wstat's mode which also is the perms to make things
more confusing...)

Anyway,
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>

--
Dominique