Re: [PATCH v4 08/11] fs/9p: Add new mount modes

asmadeus
2023-02-18T08:47:21Z

Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:20AM +0000:
> Add some additional mount modes for cache management including
> specifying directio as a mount option and an option for ignore
> qid.version for determining whether or not a file is cacheable.

direct io is standard enough but ignore QV probably warrants a comment
in the code and not just a word in the commit message.

I see you've added these in Documentation/filesystems/9p.rst in
the "writeback mode fixes" -- I guess we can live with commits
introducing options not being 100% coherent within the series (the
implementation also comes in that fixes commit), but perhaps a '/*
ignore qid.version */' comment in the enum?

> diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h
> index d90141d25d0d..48c7614c9333 100644
> --- a/fs/9p/v9fs.h
> +++ b/fs/9p/v9fs.h
> @@ -37,7 +37,10 @@ enum p9_session_flags {
> V9FS_ACCESS_USER = 0x08,
> V9FS_ACCESS_CLIENT = 0x10,
> V9FS_POSIX_ACL = 0x20,
> - V9FS_NO_XATTR = 0x40
> + V9FS_NO_XATTR = 0x40,
> + V9FS_IGNORE_QV = 0x80,
> + V9FS_DIRECT_IO = 0x100,
> + V9FS_SYNC = 0x200

... And while we're here, indentation seems off on sync

--
Dominique