Re: [PATCH v4 07/11] 9p: Add additional debug flags and open modes

asmadeus
2023-02-18T08:05:44Z

Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:19AM +0000:
> Add some additional debug flags to assist with debugging
> cache changes. Also add some additional open modes so we
> can track cache state in fids more directly.
>
> Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>

New debug flags can't hurt.

For open modes: don't we send the mode verbatim to servers? won't they
be confused?
I guess I'll see in the next patch if you trim it down, but we might
want to add a P9_MODE_MASK or something with values we're allowed to
send and have client.c filter it out?

--
Dominique