Re: [PATCH v5 0/3] Add pinctrl support for S32 SoC family

Andy Shevchenko
2023-03-07T09:56:31Z

On Tue, Mar 7, 2023 at 11:22 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Tue, Mar 7, 2023 at 12:28 AM <andy.shevchenko@gmail.com> wrote:

...

> > Can you unpull this?

> If need be.
>
> Are there serious issues with the patch set such that they cannot be fixed
> by add-on patches?

There are a few absent error checks, some error code shadowing, etc.
I can't tell if these all are serious, but the amount of them is like a dozen.

I reviewed the patch, so you can look into that yourself and decide.

--
With Best Regards,
Andy Shevchenko