Re: [PATCH] x86/bugs: Allow STIBP with IBRS

Josh Poimboeuf
2023-02-20T19:02:30Z

On Mon, Feb 20, 2023 at 10:33:56AM -0800, KP Singh wrote:
> static char *stibp_state(void)
> {
> - if (spectre_v2_in_ibrs_mode(spectre_v2_enabled))
> + if (!spectre_v2_user_needs_stibp(spectre_v2_enabled))
> return "";
>
> switch (spectre_v2_user_stibp) {
>
> Also Josh, is it okay for us to have a discussion and have me write
> the patch as a v2? Your current patch does not even credit me at all.
> Seems a bit unfair, but I don't really care. I was going to rev up the
> patch with your suggestions.

Well, frankly the patch needed a complete rewrite. The patch
description was unclear about what the problem is and what's being
fixed. The code was obtuse and the comments didn't help. I could tell
by the other replies that I wasn't the only one confused.

I can give you Reported-by, or did you have some other tag in mind?

--
Josh