Re: [PATCH v4 0/4] tools/nolibc: Adding stdint.h, more integer types and tests

Vincent Dagonneau
2023-02-10T13:03:30Z

On Wed, Feb 8, 2023, at 22:43, Willy Tarreau wrote:
> On Wed, Feb 08, 2023 at 09:40:40PM -0500, Vincent Dagonneau wrote:
>> Hi,
>>
>> This is version 4 of my patch to add stdint.h to nolibc. Previous
>> versions of this patch are available here:
>>
>> * v3: https://lore.kernel.org/all/20230206013248.471664-1-v@vda.io/
>> * v2: https://lore.kernel.org/all/20230202201101.43160-1-v@vda.io/
>> * v1: https://lore.kernel.org/all/20230202160236.25342-1-v@vda.io/
>>
>> I tested it successfully on x86_64, as well as i386 and arm on qemu.
>>
>> Thank you Willy for the review and the guidance!
>> Vincent.
>
> Thanks Vincent. At first glance it looks good. I'll give it a try on
> all supported archs to make sure we didn't overlook anything and we'll
> merge it. One tiny comment though, look below:
>
>> Vincent Dagonneau (4):
>> tools/nolibc: Adding stdint.h
>> tools/nolibc: Adding integer types and integer limit macros
>> tools/nolibc: Enlarging column width of tests
>> tools/nolibc: Adds tests for the integer limits in stdint.h
>
> I mentioned in the first review that it's generally preferred to use
> the imperative form rather than present participle on subject lines.
> This would give:
>
> tools/nolibc: Add stdint.h
> tools/nolibc: Add integer types and integer limit macros
> tools/nolibc: Enlarge column width of tests
> tools/nolibc: Add tests for the integer limits in stdint.h
>
> I can perform this trivial change locally before merging without asking
> you to respin a series just for this if that's OK for you. Just let me
> know.
>
> Thanks!
> Willy

Yep, go ahead!

Thank you again for the guidance,
Vincent.