Re: [PATCH v3 3/5] iommu/sva: Stop using ioasid_set for SVA

Jacob Pan
2023-02-22T06:15:27Z

Hi Kevin,

On Wed, 22 Feb 2023 02:22:48 +0000, "Tian, Kevin" <kevin.tian@intel.com>
wrote:

> > From: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Sent: Friday, February 17, 2023 8:00 AM
> >
> > + ret = ida_alloc_range(&iommu_global_pasid_ida, min, max,
> > GFP_KERNEL);
> > + if (ret < min)
> > + goto out;
>
> ioasid_alloc() currently uses GFP_ATOMIC.
>
> since this is kind of a replacement w/o functional impact, it'd be cleaner
> from bisect p.o.v. to have a separate patch changing GFP_ATOMIC
> to GFP_KERNEL in ioasid_alloc() and then this patch.
>
makes sense,

Thanks,

Jacob