Re: [PATCH] HID: usbhid: enable remote wakeup for mice

Benson Leung
2011-10-14T14:58:41Z

Thanks for the prompt response.

My initial reasoning was to set as default the wakeup behavior so a
mouse button press would wake the system. I am well aware that most if
not all mice don't support wake on move, but at least wake on button
press would have been more desirable than doing nothing.

Anyway, I'll solve this problem on my system by writing to wakeup
property on device attach. Consider my change abandoned.

Thanks,
Benson

On Fri, Oct 14, 2011 at 7:00 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Fri, 14 Oct 2011, Alan Stern wrote:
>
>> In addition, unlike keyboards, a lot of mice don't work very well when
>> they are suspended.  For example, many won't wake up when they are
>> moved (especially optical mice) and some don't even wake up when a
>> button is pressed.
>
> To stress it even more, I have tried with various types and brands of
> optical mouse, and I haven't encountered a single one that would wake up
> when moved.
>
>> This patch definitely should not be merged.
>
> I am not planning to do that.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

--
Benson Leung
Software Engineer, Chrom* OS
bleung@chromium.org