Re: [PATCH] HID: usbhid: enable remote wakeup for mice

Alan Stern
2011-10-14T15:09:34Z

On Fri, 14 Oct 2011, Benson Leung wrote:

> Thanks for the prompt response.
>
> My initial reasoning was to set as default the wakeup behavior so a
> mouse button press would wake the system. I am well aware that most if
> not all mice don't support wake on move, but at least wake on button
> press would have been more desirable than doing nothing.

I'm sorry, I misunderstood the purpose of the original patch. Probably
read it too quickly -- I thought you were enabling autosuspend rather
than wakeup.

Enabling wakeup by default has its own problems. Some mice do send
wakeup requests when they are moved. You wouldn't want a stray motion
or unintentional touch to wake up a sleeping system. Or at least, a
lot of people wouldn't want that.

> Anyway, I'll solve this problem on my system by writing to wakeup
> property on device attach. Consider my change abandoned.

That seems like the best approach.

Alan Stern