Re: [PATCH] HID: usbhid: enable remote wakeup for mice

Alan Stern
2011-10-14T13:56:29Z

On Fri, 14 Oct 2011, Oliver Neukum wrote:

> Am Freitag, 14. Oktober 2011, 09:54:48 schrieb Benson Leung:
> > This patch enables remote wakeup by default on USB mouse
> > devices. This only covers USB mice that support
> > the boot protocol. See commit 3d61510f for the
> > equivalent patch for USB keyboard devices.
>
> This doesn't loo like a very good idea.
> Firstly your patch introduces gratious change in the hid driver.
> Secondly you are changing the usbmouse driver, which is to
> be used under special circumstances only, only.
> Thirdly a fundamental change like that needs a commit entry
> explaining the reason for the change.

In addition, unlike keyboards, a lot of mice don't work very well when
they are suspended. For example, many won't wake up when they are
moved (especially optical mice) and some don't even wake up when a
button is pressed.

This patch definitely should not be merged.

Alan Stern