public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Weichen Chen <weichen.chen@mediatek.com>
To: <weichen.chen@mediatek.com>, <yt.shen@mediatek.com>,
	<darren.chen@mediatek.com>, <keescook@chromium.org>,
	<tony.luck@intel.com>, <angelogioacchino.delregno@collabora.com>,
	<matthias.bgg@gmail.com>, <gpiccoli@igalia.com>,
	<linux-hardening@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v1 1/1] pstore/ram: Fix crash when setting number of cpus to an odd number
Date: Fri, 24 Feb 2023 10:36:32 +0800	[thread overview]
Message-ID: <20230224023632.6840-1-weichen.chen@mediatek.com> (raw)

When the number of cpu cores is adjusted to 7 or other odd numbers,
the zone size will become an odd number.
The address of the zone will become:
    addr of zone0 = BASE
    addr of zone1 = BASE + zone_size
    addr of zone2 = BASE + zone_size*2
    ...
The address of zone1/3/5/7 will be mapped to non-alignment va.
Eventually crashes will occur when accessing these va.

So, use ALIGN_DOWN() to make sure the zone size is even
to avoid this bug.

Signed-off-by: Weichen Chen <weichen.chen@mediatek.com>
---
 fs/pstore/ram.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
index ade66dbe5f39..fc57ac97e506 100644
--- a/fs/pstore/ram.c
+++ b/fs/pstore/ram.c
@@ -528,6 +528,7 @@ static int ramoops_init_przs(const char *name,
 	}
 
 	zone_sz = mem_sz / *cnt;
+	zone_sz = ALIGN_DOWN(zone_sz, 2);
 	if (!zone_sz) {
 		dev_err(dev, "%s zone size == 0\n", name);
 		goto fail;
-- 
2.18.0


             reply	other threads:[~2023-02-24  2:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24  2:36 Weichen Chen [this message]
2023-02-24  4:00 ` [PATCH v1 1/1] pstore/ram: Fix crash when setting number of cpus to an odd number Guilherme G. Piccoli
2023-02-24 10:07   ` Matthias Brugger
2023-02-24  7:05 ` Miko Larsson
2023-11-08 22:42 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230224023632.6840-1-weichen.chen@mediatek.com \
    --to=weichen.chen@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=darren.chen@mediatek.com \
    --cc=gpiccoli@igalia.com \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=tony.luck@intel.com \
    --cc=yt.shen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox