From: void0red <void0red@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
void0red <void0red@gmail.com>
Subject: [PATCH] usb: gadget: udc: add return value check of kzalloc in mv_udc_probe
Date: Fri, 24 Feb 2023 16:08:42 +0800 [thread overview]
Message-ID: <20230224080842.3104911-1-void0red@gmail.com> (raw)
Even an 8-byte kzalloc will fail when we don't have enough memory,
so we need a nullptr check and do the cleanup when it fails.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217081
Signed-off-by: void0red <void0red@gmail.com>
---
drivers/usb/gadget/udc/mv_udc_core.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c
index b397f3a84..6dd6d52de 100644
--- a/drivers/usb/gadget/udc/mv_udc_core.c
+++ b/drivers/usb/gadget/udc/mv_udc_core.c
@@ -2230,6 +2230,10 @@ static int mv_udc_probe(struct platform_device *pdev)
/* allocate a small amount of memory to get valid address */
udc->status_req->req.buf = kzalloc(8, GFP_KERNEL);
+ if (!udc->status_req->req.buf) {
+ retval = -ENOMEM;
+ goto err_destroy_dma;
+ }
udc->status_req->req.dma = DMA_ADDR_INVALID;
udc->resume_state = USB_STATE_NOTATTACHED;
--
2.34.1
next reply other threads:[~2023-02-24 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 8:08 void0red [this message]
2023-02-24 8:36 ` [PATCH] usb: gadget: udc: add return value check of kzalloc in mv_udc_probe Greg KH
-- strict thread matches above, loose matches on Subject: below --
2023-02-24 9:20 void0red
2023-02-24 11:03 ` Dongliang Mu
2023-02-24 12:43 ` Kang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224080842.3104911-1-void0red@gmail.com \
--to=void0red@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox